Bug 1114175
| Summary: | Review Request: golang-github-codegangsta-cli - Package for building command line apps in Go | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lokesh Mandvekar <lsm5> | ||||
| Component: | Package Review | Assignee: | Vincent Batts <vbatts> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | package-review | ||||
| Target Milestone: | --- | Flags: | vbatts:
fedora-review+
gwync: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | golang-github-codegangsta-cli-1.2.0-2.el6 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-08-15 18:57:37 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1055712, 1111916, 1118603, 1124036 | ||||||
| Attachments: |
|
||||||
|
Description
Lokesh Mandvekar
2014-06-28 04:35:19 UTC
Vincent, let me know if this should block docker/libcontainer review or if it's better for libcontainer to proceed without this for now. And feel free to re-assign this :) Created attachment 918503 [details]
spec tweaks
Points addressed in the attached patch:
* remove boiler-plate, to use golang rpm macros instead
* preserve timestamps of copied source
* don't own directories that golang owns
%changelog * Wed Jul 16 2014 Lokesh Mandvekar <lsm5> - 1.0.0-2 - From: Vincent Batts <vbatts> - remove boiler-plate, to use golang rpm macros instead - preserve timestamps of copied source - don't own directories that golang owns Spec URL: http://lsm5.fedorapeople.org/golang-github-codegangsta-cli/golang-github-codegangsta-cli.spec SRPM URL: http://lsm5.fedorapeople.org/golang-github-codegangsta-cli/SRPMS/golang-github-codegangsta-cli-1.0.0-2.fc22.src.rpm one little nit, the "p" in the `cp` args
<pre>
Index: rpmbuild/SPECS/golang-github-codegangsta-cli.spec
===================================================================
--- rpmbuild.orig/SPECS/golang-github-codegangsta-cli.spec
+++ rpmbuild/SPECS/golang-github-codegangsta-cli.spec
@@ -40,7 +40,7 @@ which use codegangsta/cli.
%install
install -d -p %{buildroot}%{gopath}/src/%{import_path}
-cp -av *.go %{buildroot}%{gopath}/src/%{import_path}
+cp -pav *.go %{buildroot}%{gopath}/src/%{import_path}
%check
GOPATH=%{gopath}:%{buildroot}/%{gopath} go test %{import_path}
</pre>
argh, sorry about that. %changelog * Mon Jul 21 2014 Lokesh Mandvekar <lsm5> - 1.0.0-3 - correct cp args Spec URL: http://lsm5.fedorapeople.org/golang-github-codegangsta-cli/golang-github-codegangsta-cli.spec SRPM URL: http://lsm5.fedorapeople.org/golang-github-codegangsta-cli/SRPMS/golang-github-codegangsta-cli-1.0.0-3.fc22.src.rpm looks good. Thanks lokesh. New Package SCM Request ======================= Package Name: golang-github-codegangsta-cli Short Description: Package for building command line apps in Go Upstream URL: https://github.com/codegangsta/cli Owners: lsm5 vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig Git done (by process-git-requests). golang-github-codegangsta-cli-1.0.0-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-codegangsta-cli-1.0.0-3.fc20 golang-github-codegangsta-cli-1.0.0-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-github-codegangsta-cli-1.0.0-3.fc19 golang-github-codegangsta-cli-1.0.0-3.fc20 has been pushed to the Fedora 20 testing repository. golang-github-codegangsta-cli-1.0.0-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-codegangsta-cli-1.0.0-4.fc20 golang-github-codegangsta-cli-1.0.0-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-github-codegangsta-cli-1.0.0-4.fc19 golang-github-codegangsta-cli-1.1.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-codegangsta-cli-1.1.0-1.fc20 golang-github-codegangsta-cli-1.1.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-github-codegangsta-cli-1.1.0-1.fc19 golang-github-codegangsta-cli-1.1.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-codegangsta-cli-1.1.0-1.el6 golang-github-codegangsta-cli-1.1.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. golang-github-codegangsta-cli-1.1.0-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. golang-github-codegangsta-cli-1.1.0-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: golang-github-codegangsta-cli New Branches: epel7 Owners: lsm5 vbatts InitialCC: golang-sig Git done (by process-git-requests). golang-github-codegangsta-cli-1.2.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-codegangsta-cli-1.2.0-2.fc20 golang-github-codegangsta-cli-1.2.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-codegangsta-cli-1.2.0-2.fc21 golang-github-codegangsta-cli-1.2.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-codegangsta-cli-1.2.0-2.el6 golang-github-codegangsta-cli-1.2.0-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. golang-github-codegangsta-cli-1.2.0-2.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. golang-github-codegangsta-cli-1.2.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |