Spec URL: http://lsm5.fedorapeople.org/golang-github-docker-libcontainer/golang-github-docker-libcontainer.spec SRPM URL: http://lsm5.fedorapeople.org/golang-github-docker-libcontainer/SRPMS/golang-github-docker-libcontainer-1.0.1-1.fc20.src.rpm Description: libcontainer specifies configuration options for what a container is. It provides a native Go implementation for using Linux namespaces with no external dependencies. libcontainer provides many convenience functions for working with namespaces, networking, and management. Fedora Account System Username: lsm5 Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7065045 $ rpmlint golang-github-docker-libcontainer.spec SRPMS/golang-github-docker-libcontainer-1.0.1-1.fc20.src.rpm RPMS/noarch/golang-github-docker-libcontainer-devel-1.0.1-1.fc20.noarch.rpm golang-github-docker-libcontainer.spec:59: W: setup-not-quiet golang-github-docker-libcontainer.src: W: spelling-error %description -l en_US namespaces -> name spaces, name-spaces, names paces golang-github-docker-libcontainer.src:59: W: setup-not-quiet 2 packages and 1 specfiles checked; 0 errors, 3 warnings.
A couple of items. BuildRequires: golang(github.com/syndtr/gocapability/capability) isn't true. There is nothing during this rpmbuild that uses that library. as for runtime Requires:, this is missing: * github.com/coreos/go-systemd/dbus * github.com/dotcloud/docker/pkg/mount * github.com/dotcloud/docker/pkg/symlink * github.com/dotcloud/docker/pkg/system * github.com/dotcloud/docker/pkg/systemd * github.com/dotcloud/docker/pkg/term * github.com/dotcloud/docker/pkg/user * github.com/godbus/dbus and github.com/codegangsta/cli when we decide to start building `nsinit`
(In reply to Vincent Batts from comment #1) > A couple of items. > BuildRequires: golang(github.com/syndtr/gocapability/capability) > isn't true. There is nothing during this rpmbuild that uses that library. There's these: security/capabilities/capabilities.go: "github.com/syndtr/gocapability/capability" types.go: "github.com/syndtr/gocapability/capability" > > as for runtime Requires:, this is missing: > * github.com/coreos/go-systemd/dbus > * github.com/dotcloud/docker/pkg/mount > * github.com/dotcloud/docker/pkg/symlink > * github.com/dotcloud/docker/pkg/system > * github.com/dotcloud/docker/pkg/systemd > * github.com/dotcloud/docker/pkg/term > * github.com/dotcloud/docker/pkg/user > * github.com/godbus/dbus About the dotcloud/docker ones, won't this introduce cyclic dependencies? docker-io will be requiring this package as BuildRequires. Or can we get around that by enforcing NVR requirements > > and github.com/codegangsta/cli when we decide to start building `nsinit` This was probably cause I hadn't included any tests in %check. There's also Bug 1110497 (but I don't think I checked if that applies to this package). I'll include tests if they work fine.
Sorry, about syndtr/gocapability ..that'd be a BR only if %check is enabled I think.
argh sorry again, I hear ya about nsinit...I'll add this too
I've pushed an update to docker-io package, to support the importing of its libraries by libcontainer. http://pkgs.fedoraproject.org/cgit/docker-io.git/commit/?id=c8f25fcfd0e04ac8b7de93522459c6ac7bc64dc2 that docker-io build is here: http://koji.fedoraproject.org/koji/taskinfo?taskID=7152739
lokesh, lets include a build of the nsinit command, but include in the %description that nsinit is for debugging only, and not officially supported.
* Fri Jul 25 2014 Lokesh Mandvekar <lsm5> 1.1.0-1 - use v1.1.0 - do not own dirs owned by golang - do not redefine macros defined in golang - main package provides nsinit Spec URL: https://lsm5.fedorapeople.org/golang-github-docker-libcontainer/golang-github-docker-libcontainer.spec SRPM URL: https://lsm5.fedorapeople.org/golang-github-docker-libcontainer/SRPMS/golang-github-docker-libcontainer-1.1.0-1.fc22.src.rpm nsinit is an archful binary, so don't think we can make this noarch anymore
(In reply to Vincent Batts from comment #9) > lokesh, lets include a build of the nsinit command, but include in the > %description that nsinit is for debugging only, and not officially supported. updating yet again with this addressed
%changelog * Fri Jul 25 2014 Lokesh Mandvekar <lsm5> - 1.1.0-2 - nsinit description: debugging only and no official support Spec URL: https://lsm5.fedorapeople.org/golang-github-docker-libcontainer/golang-github-docker-libcontainer.spec SRPM URL: https://lsm5.fedorapeople.org/golang-github-docker-libcontainer/SRPMS/golang-github-docker-libcontainer-1.1.0-2.fc22.src.rpm
%changelog * Mon Jul 28 2014 Lokesh Mandvekar <lsm5> - 1.1.0-3 - nsinit needs docker-io-pkg-devel to build Spec URL: https://lsm5.fedorapeople.org/golang-github-docker-libcontainer/golang-github-docker-libcontainer.spec SRPM URL: https://lsm5.fedorapeople.org/golang-github-docker-libcontainer/SRPMS/golang-github-docker-libcontainer-1.1.0-3.fc22.src.rpm
Since Vincent is on PTO, I'll take this to move it forward.
Thanks Marek! %changelog * Wed Jul 30 2014 Lokesh Mandvekar <lsm5> - 1.1.0-4 - Update BRs for main package Spec URL: https://lsm5.fedorapeople.org/golang-github-docker-libcontainer/golang-github-docker-libcontainer.spec SRPM URL: https://lsm5.fedorapeople.org/golang-github-docker-libcontainer/SRPMS/golang-github-docker-libcontainer-1.1.0-4.fc22.src.rpm Koji build works: http://koji.fedoraproject.org/koji/taskinfo?taskID=7215943
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ISSUES: [!]: License file installed when any subpackage combination is installed. * Please add the LICENSE file to the main package: %doc LICENSE OTHER: * You don't need %defattr in %files section. * I'm not sure if the %attr for each file is not necessary since this looks for me as the default. Feel free to leave it as-is. APPROVED, you can fix the issue at the import time. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". [!]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang- github-docker-libcontainer-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-docker-libcontainer-1.1.0-4.fc22.x86_64.rpm golang-github-docker-libcontainer-devel-1.1.0-4.fc22.x86_64.rpm golang-github-docker-libcontainer-1.1.0-4.fc22.src.rpm golang-github-docker-libcontainer.x86_64: W: spelling-error %description -l en_US namespaces -> name spaces, name-spaces, names paces golang-github-docker-libcontainer.x86_64: W: unstripped-binary-or-object /usr/bin/nsinit golang-github-docker-libcontainer.x86_64: W: no-documentation golang-github-docker-libcontainer.x86_64: W: no-manual-page-for-binary nsinit golang-github-docker-libcontainer.src: W: spelling-error %description -l en_US namespaces -> name spaces, name-spaces, names paces golang-github-docker-libcontainer.src: W: spelling-error %description -l en_US nsinit -> insist golang-github-docker-libcontainer.src:19: W: unversioned-explicit-provides nsinit golang-github-docker-libcontainer.src:65: W: setup-not-quiet 3 packages and 0 specfiles checked; 0 errors, 8 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint golang-github-docker-libcontainer-devel golang-github-docker-libcontainer golang-github-docker-libcontainer.x86_64: W: spelling-error %description -l en_US namespaces -> name spaces, name-spaces, names paces golang-github-docker-libcontainer.x86_64: W: unstripped-binary-or-object /usr/bin/nsinit golang-github-docker-libcontainer.x86_64: W: no-documentation golang-github-docker-libcontainer.x86_64: W: no-manual-page-for-binary nsinit 2 packages and 0 specfiles checked; 0 errors, 4 warnings. # echo 'rpmlint-done:' Requires -------- golang-github-docker-libcontainer-devel (rpmlib, GLIBC filtered): golang golang(github.com/syndtr/gocapability/capability) golang-github-docker-libcontainer (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) Provides -------- golang-github-docker-libcontainer-devel: golang(github.com/docker/libcontainer) golang(github.com/docker/libcontainer/apparmor) golang(github.com/docker/libcontainer/cgroups) golang(github.com/docker/libcontainer/cgroups/fs) golang(github.com/docker/libcontainer/cgroups/systemd) golang(github.com/docker/libcontainer/console) golang(github.com/docker/libcontainer/devices) golang(github.com/docker/libcontainer/label) golang(github.com/docker/libcontainer/mount) golang(github.com/docker/libcontainer/mount/nodes) golang(github.com/docker/libcontainer/namespaces) golang(github.com/docker/libcontainer/netlink) golang(github.com/docker/libcontainer/network) golang(github.com/docker/libcontainer/nsinit) golang(github.com/docker/libcontainer/security/capabilities) golang(github.com/docker/libcontainer/security/restrict) golang(github.com/docker/libcontainer/selinux) golang(github.com/docker/libcontainer/utils) golang-github-docker-libcontainer-devel golang-github-docker-libcontainer-devel(x86-64) golang-github-docker-libcontainer: golang-github-docker-libcontainer golang-github-docker-libcontainer(x86-64) nsinit Source checksums ---------------- https://github.com/docker/libcontainer/archive/v1.1.0.tar.gz : CHECKSUM(SHA256) this package : 992a0a83d8d1df8cb85b3f6c8dd0ee46cc5f4c4cb64690ef5a7c62d697e39ce4 CHECKSUM(SHA256) upstream package : 992a0a83d8d1df8cb85b3f6c8dd0ee46cc5f4c4cb64690ef5a7c62d697e39ce4 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -m fedora-rawhide-x86_64 -v -b 1111916 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Cool thanks! * Wed Jul 30 2014 Lokesh Mandvekar <lsm5> - 1.1.0-5 - LICENSE file installed in main package - defattr gotten rid of (The attr I think is still an el6 requirement, leaving it as-is) Spec URL: https://lsm5.fedorapeople.org/golang-github-docker-libcontainer/golang-github-docker-libcontainer.spec SRPM URL: https://lsm5.fedorapeople.org/golang-github-docker-libcontainer/SRPMS/golang-github-docker-libcontainer-1.1.0-5.fc22.src.rpm SCM request to follow ..
New Package SCM Request ======================= Package Name: golang-github-docker-libcontainer Short Description: Configuration options for containers Upstream URL: https://github.com/docker/libcontainer Owners: lsm5 mgoldman vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig
WARNING: "mgoldman" is not a valid FAS account.
It's probably mgoldmann ... I'll add Marek later. New request below: New Package SCM Request ======================= Package Name: golang-github-docker-libcontainer Short Description: Configuration options for containers Upstream URL: https://github.com/docker/libcontainer Owners: lsm5 vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig
(In reply to Lokesh Mandvekar from comment #20) > It's probably mgoldmann ... I'll add Marek later. New request below: It is "goldmann" :) It's not necessary to add me to this package.
Git done (by process-git-requests).
golang-github-docker-libcontainer-1.1.0-6.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-docker-libcontainer-1.1.0-6.fc20
golang-github-docker-libcontainer-1.1.0-6.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-github-docker-libcontainer-1.1.0-6.fc19
golang-github-docker-libcontainer-1.1.0-6.fc20 has been pushed to the Fedora 20 testing repository.
golang-github-docker-libcontainer-1.1.0-6.fc20 has been pushed to the Fedora 20 stable repository.
golang-github-docker-libcontainer-1.1.0-6.fc19 has been pushed to the Fedora 19 stable repository.
nsinit stats doesn't work, see https://bugzilla.redhat.com/show_bug.cgi?id=1130500