Bug 1114210

Summary: Review Request: sispmctl - Control Gembird SIS-PM programmable power outlet strips
Product: [Fedora] Fedora Reporter: Jiri Pirko <jpirko>
Component: Package ReviewAssignee: Dan Horák <dan>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: dan, jiri, jpirko, package-review, rkhan
Target Milestone: ---Flags: dan: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-06-30 15:27:17 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jiri Pirko 2014-06-28 17:35:38 UTC 
Spec URL: http://people.redhat.com/jpirko/fedora_pkg_review/sispmctl_1/sispmctl.spec
SRPM URL: http://people.redhat.com/jpirko/fedora_pkg_review/sispmctl_1/sispmctl-3.1-1.fc20.src.rpm
Description:
The sispmctl tool can control Gembird SIS-PM Silver Shield programmable
power outlet strips (also known under the name Revolt Intelli-Plug)
from the command line.

It can be used to switch on or off any of the programmable power sockets of
the SIS-PM via USB. It can also show the current status of each power socket,
and it can handle multiple SIS-PM devices, too. 
Fedora Account System Username: jirka
Comment 1 Dan Horák 2014-06-28 20:11:45 UTC 
formal review is here, see the notes explaining OK* and BAD statuses below:

OK      source files match upstream:
            f89d2820ca48794b80df81309910299dbc1278e1  sispmctl-3.1.tar.gz
OK      package meets naming and versioning guidelines.
OK      specfile is properly named, is cleanly written and uses macros consistently.
OK      dist tag is present.
OK      license field matches the actual license.
OK      license is open source-compatible (GPLv2+). License text included in package.
OK      latest version is being packaged.
Ok      BuildRequires are proper.
OK      compiler flags are appropriate.
OK      package builds in mock (Rawhide/x86_64).
OK      debuginfo package looks complete.
OK*     rpmlint is silent.
OK      final provides and requires look sane.
N/A     %check is present and all tests pass.
OK      no shared libraries are added to the regular linker search paths.
OK      owns the directories it creates.
OK      doesn't own any directories it shouldn't.
OK      no duplicates in %files.
OK      file permissions are appropriate.
OK      no scriptlets present.
OK      code, not content.
OK      documentation is small, so no -docs subpackage is necessary.
OK      %docs are not necessary for the proper functioning of the package.
OK      no headers.
OK      no pkgconfig files.
OK      no libtool .la droppings.
OK      not a GUI app.

- rpmlint complains about "incorrect-fsf-address", please let upstream know about this issue

The package is APPROVED.
Comment 2 Jiri Pirko 2014-06-29 09:26:50 UTC 
New Package SCM Request
=======================
Package Name: sispmctl
Short Description: Control Gembird SIS-PM programmable power outlet strips
Upstream URL: http://sispmctl.sourceforge.net/
Owners: jirka
Branches: f19 f20 el6 epel7
Comment 3 Gwyn Ciesla 2014-06-30 12:26:26 UTC 
Git done (by process-git-requests).