Spec URL: http://people.redhat.com/jpirko/fedora_pkg_review/sispmctl_1/sispmctl.spec SRPM URL: http://people.redhat.com/jpirko/fedora_pkg_review/sispmctl_1/sispmctl-3.1-1.fc20.src.rpm Description: The sispmctl tool can control Gembird SIS-PM Silver Shield programmable power outlet strips (also known under the name Revolt Intelli-Plug) from the command line. It can be used to switch on or off any of the programmable power sockets of the SIS-PM via USB. It can also show the current status of each power socket, and it can handle multiple SIS-PM devices, too. Fedora Account System Username: jirka
formal review is here, see the notes explaining OK* and BAD statuses below: OK source files match upstream: f89d2820ca48794b80df81309910299dbc1278e1 sispmctl-3.1.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible (GPLv2+). License text included in package. OK latest version is being packaged. Ok BuildRequires are proper. OK compiler flags are appropriate. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK* rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - rpmlint complains about "incorrect-fsf-address", please let upstream know about this issue The package is APPROVED.
New Package SCM Request ======================= Package Name: sispmctl Short Description: Control Gembird SIS-PM programmable power outlet strips Upstream URL: http://sispmctl.sourceforge.net/ Owners: jirka Branches: f19 f20 el6 epel7
Git done (by process-git-requests).