Bug 1115491

Summary:	Review Request: rubygem-shoulda-context - Context framework extracted from Shoulda
Product:	[Fedora] Fedora	Reporter:	Vít Ondruch <vondruch>
Component:	Package Review	Assignee:	Josef Stribny <jstribny>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	hhorak, jstribny, package-review
Target Milestone:	---	Flags:	jstribny: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rubygem-shoulda-context-1.2.1-1.fc21	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-07-07 07:27:45 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1060172, 1115554

Description Vít Ondruch 2014-07-02 13:08:14 UTC

Spec URL: http://people.redhat.com/vondruch/rubygem-shoulda-context.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-shoulda-context-1.2.1-1.fc21.src.rpm
Description:
Shoulda's contexts make it easy to write understandable and maintainable
tests for Test::Unit. It's fully compatible with your existing tests in
Test::Unit, and requires no retooling to use.

Refer to the shoulda gem if you want to know more about using shoulda
with Rails or RSpec.

Fedora Account System Username: vondruch

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7099563


This package was retired previously, so this is re-review to bring it back to the live again.

Comment 1 Josef Stribny 2014-07-02 13:09:30 UTC

I will take it for a review.

Comment 2 Josef Stribny 2014-07-02 13:51:31 UTC

* According to the guidelines the description of the sub-package should end with a dot (.) -> Documentation for %{name}.

Otherwise the spec looks good, rpmlint does not compain, package builds, installs, runs. Please fix the minor issue before pushing. ==> APPROVED.

Comment 3 Vít Ondruch 2014-07-02 14:33:56 UTC

Thanks for the re-review!



Package Change Request
======================
Package Name: rubygem-shoulda-context
New Branches: master
Owners: vondruch
InitialCC:

Comment 4 Gwyn Ciesla 2014-07-03 12:11:11 UTC

Misformatted request.

Comment 5 Vít Ondruch 2014-07-03 12:28:35 UTC

Package Change Request
======================
Package Name: rubygem-shoulda-context
New Branches:
Owners: vondruch
InitialCC:

So lets try without the master. Master is retired and I care just about master.

Comment 6 Gwyn Ciesla 2014-07-03 12:42:39 UTC

What is the intention of this request?

Comment 7 Vít Ondruch 2014-07-03 12:55:01 UTC

This is re-review of retired package. The intention is to unretire the package at master. So may be there should be not "change request" at all?

Comment 8 Gwyn Ciesla 2014-07-03 13:48:03 UTC

Got it, done.

Comment 9 Vít Ondruch 2014-07-07 07:27:45 UTC

Thanks Jon!