Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://people.redhat.com/vondruch/rubygem-shoulda-matchers.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-shoulda-matchers-2.6.1-1.fc21.src.rpm Description: shoulda-matchers provides Test::Unit- and RSpec-compatible one-liners that test common Rails functionality. These tests would otherwise be much longer, more complex, and error-prone. Fedora Account System Username: vondruch
* Change upstream URL to git repo (ideally), http://thoughtbot.com/community/ is just a redirect. * This should be probably filled to upstream (and I realize now its the same thing for shoulda-context): # Fix wrong-file-end-of-line-encoding for rpmlint. sed -i 's/\r$//' MIT-LICENSE * According to the guidelines[0] you should version ruby(release): BuildRequires: ruby(release) BuildRequires: ruby >= 1.9.2 * Package build fails: From the log: > bundle install --local > Resolving dependencies... > Could not find gem 'shoulda-context (~> 1.2.0) ruby' in the gems available on > this machine. You need to BuildRequires: rubygem(shoulda-context) [0] https://fedoraproject.org/wiki/Packaging:Ruby
(In reply to Josef Stribny from comment #1) > * Change upstream URL to git repo (ideally), > http://thoughtbot.com/community/ is just a redirect. Good idea. Not sure why they have this silly URL in gem :/ > * This should be probably filled to upstream (and I realize now its the same > thing for shoulda-context): > > # Fix wrong-file-end-of-line-encoding for rpmlint. > sed -i 's/\r$//' MIT-LICENSE That is questionable. These are Mac line endings, if I was Mac developer, I'd not bother. > * According to the guidelines[0] you should version ruby(release): > > BuildRequires: ruby(release) > BuildRequires: ruby >= 1.9.2 Fixed. > * Package build fails: > > From the log: > > > bundle install --local > > Resolving dependencies... > > Could not find gem 'shoulda-context (~> 1.2.0) ruby' in the gems available on > > this machine. > > You need to BuildRequires: rubygem(shoulda-context) Good catch. I missed it since I had to install it manually into my test build root. Spec URL: http://people.redhat.com/vondruch/rubygem-shoulda-matchers.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-shoulda-matchers-2.6.1-2.fc21.src.rpm
Package builds, installs, runs. Spec is sane. Fixes were made. APPROVED.
Thanks for the review! New Package SCM Request ======================= Package Name: vondruch Short Description: Making tests easy on the fingers and eyes Upstream URL: https://github.com/thoughtbot/shoulda-matchers Owners: vondruch Branches: InitialCC:
Misformatted request. Check package name.
Ups, sorry, now it should be correct. New Package SCM Request ======================= Package Name: rubygem-shoulda-matchers Short Description: Making tests easy on the fingers and eyes Upstream URL: https://github.com/thoughtbot/shoulda-matchers Owners: vondruch Branches: InitialCC:
Git done (by process-git-requests).