Bug 1115554
| Summary: | Review Request: rubygem-shoulda-matchers - Making tests easy on the fingers and eyes | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Vít Ondruch <vondruch> |
| Component: | Package Review | Assignee: | Josef Stribny <jstribny> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hhorak, jstribny, package-review |
| Target Milestone: | --- | Flags: | jstribny:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-shoulda-matchers-2.6.1-3.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-07-07 11:45:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1115491 | ||
| Bug Blocks: | 1060172 | ||
|
Description
Vít Ondruch
2014-07-02 15:25:47 UTC
* Change upstream URL to git repo (ideally), http://thoughtbot.com/community/ is just a redirect. * This should be probably filled to upstream (and I realize now its the same thing for shoulda-context): # Fix wrong-file-end-of-line-encoding for rpmlint. sed -i 's/\r$//' MIT-LICENSE * According to the guidelines[0] you should version ruby(release): BuildRequires: ruby(release) BuildRequires: ruby >= 1.9.2 * Package build fails: From the log: > bundle install --local > Resolving dependencies... > Could not find gem 'shoulda-context (~> 1.2.0) ruby' in the gems available on > this machine. You need to BuildRequires: rubygem(shoulda-context) [0] https://fedoraproject.org/wiki/Packaging:Ruby (In reply to Josef Stribny from comment #1) > * Change upstream URL to git repo (ideally), > http://thoughtbot.com/community/ is just a redirect. Good idea. Not sure why they have this silly URL in gem :/ > * This should be probably filled to upstream (and I realize now its the same > thing for shoulda-context): > > # Fix wrong-file-end-of-line-encoding for rpmlint. > sed -i 's/\r$//' MIT-LICENSE That is questionable. These are Mac line endings, if I was Mac developer, I'd not bother. > * According to the guidelines[0] you should version ruby(release): > > BuildRequires: ruby(release) > BuildRequires: ruby >= 1.9.2 Fixed. > * Package build fails: > > From the log: > > > bundle install --local > > Resolving dependencies... > > Could not find gem 'shoulda-context (~> 1.2.0) ruby' in the gems available on > > this machine. > > You need to BuildRequires: rubygem(shoulda-context) Good catch. I missed it since I had to install it manually into my test build root. Spec URL: http://people.redhat.com/vondruch/rubygem-shoulda-matchers.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-shoulda-matchers-2.6.1-2.fc21.src.rpm Package builds, installs, runs. Spec is sane. Fixes were made. APPROVED. Thanks for the review! New Package SCM Request ======================= Package Name: vondruch Short Description: Making tests easy on the fingers and eyes Upstream URL: https://github.com/thoughtbot/shoulda-matchers Owners: vondruch Branches: InitialCC: Misformatted request. Check package name. Ups, sorry, now it should be correct. New Package SCM Request ======================= Package Name: rubygem-shoulda-matchers Short Description: Making tests easy on the fingers and eyes Upstream URL: https://github.com/thoughtbot/shoulda-matchers Owners: vondruch Branches: InitialCC: Git done (by process-git-requests). |