Bug 1116451

Summary:	Remove / update old rpc code
Product:	Red Hat OpenStack	Reporter:	Alan Pevec <apevec>
Component:	python-django-horizon	Assignee:	Matthias Runge <mrunge>
Status:	CLOSED EOL	QA Contact:	Ido Ovadia <iovadia>
Severity:	medium	Docs Contact:
Priority:	low
Version:	4.0	CC:	aberezin, aortega, apevec, athomas, chrisw, dmaley, esammons, fpercoco, iboverma, ihrachys, jross, kgiusti, lhh, lpeer, markmc, mrunge, ndipanov, nyechiel, oblaut, pematous, sclewis, tross, tshefi, yeylon, zkraus
Target Milestone:	async	Keywords:	Reopened, Triaged, ZStream
Target Release:	4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1116432	Environment:
Last Closed:	2015-06-19 17:57:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Alan Pevec 2014-07-04 16:36:10 UTC

This needs to go out asap, MRG2 update has been released
http://rhn.redhat.com/errata/RHBA-2014-0804.html
which requires routing key to be specified in the address for a direct producer

NB Horizon imported oslo rpc long ago[1] as a prep for feature which was never implemented. Juno Horizon does not have oslo rpc and does not use oslo.messaging.


[1]  github.com/openstack/horizon/commit/c519f12729002b70de4fd4c58134601df0abbd06

Comment 1 Matthias Runge 2014-07-07 13:11:23 UTC

I don't think, we're using that part at all. Ep. we don't have a dependency on qpid.

Comment 2 Alan Pevec 2014-07-07 14:05:14 UTC

Please remove that code then.

Comment 4 Ihar Hrachyshka 2014-07-10 08:31:39 UTC

@Matthias, if you have the RPC code from incubator, you should update it. If it's not used, remove RPC layer from the tree. You should not remove ALL the code from openstack/common subtree, openstack/common/rpc (and notifier if present and not used?) only.

But if any module actually imports anything from RPC module, it should be patched.

Comment 5 Alan Pevec 2014-07-10 10:03:55 UTC

(In reply to Alan Pevec from comment #2)
> Please remove that code then.

What Ihar said, "that code" := openstack_dashboard/openstack/common/rpc/

Comment 6 Matthias Runge 2014-07-16 09:42:00 UTC

We have tested on a system set up by QE. (puddle from May 28th). I haven't seen any issue, esp. no issue with swift. As far as I saw, swiftclient integration is the only part using bits from openstack_dashboard/openstack/common

Comment 7 Lon Hohberger 2014-08-04 17:39:09 UTC

It sounds like this is a clean-up that doesn't cause functional issues with Horizon.  As a consequence, I am changing the bug synopsis.

Comment 8 Scott Lewis 2015-06-19 17:57:38 UTC

This bug has been closed because OSP-4 has reached its end of life: https://rhn.redhat.com/errata/RHSA-2015-1127.html