Bug 1116451 - Remove / update old rpc code
Summary: Remove / update old rpc code
Keywords:
Status: CLOSED EOL
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: python-django-horizon
Version: 4.0
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: async
: 4.0
Assignee: Matthias Runge
QA Contact: Ido Ovadia
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-07-04 16:36 UTC by Alan Pevec
Modified: 2019-09-09 15:32 UTC (History)
25 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of: 1116432
Environment:
Last Closed: 2015-06-19 17:57:38 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Apache JIRA QPID-5557 0 None None None Never
Launchpad 1300318 0 None None None Never
OpenStack gerrit 99317 0 None None None Never

Description Alan Pevec 2014-07-04 16:36:10 UTC 
This needs to go out asap, MRG2 update has been released
http://rhn.redhat.com/errata/RHBA-2014-0804.html
which requires routing key to be specified in the address for a direct producer

NB Horizon imported oslo rpc long ago[1] as a prep for feature which was never implemented. Juno Horizon does not have oslo rpc and does not use oslo.messaging.


[1]  github.com/openstack/horizon/commit/c519f12729002b70de4fd4c58134601df0abbd06
Comment 1 Matthias Runge 2014-07-07 13:11:23 UTC 
I don't think, we're using that part at all. Ep. we don't have a dependency on qpid.
Comment 2 Alan Pevec 2014-07-07 14:05:14 UTC 
Please remove that code then.
Comment 4 Ihar Hrachyshka 2014-07-10 08:31:39 UTC 
@Matthias, if you have the RPC code from incubator, you should update it. If it's not used, remove RPC layer from the tree. You should not remove ALL the code from openstack/common subtree, openstack/common/rpc (and notifier if present and not used?) only.

But if any module actually imports anything from RPC module, it should be patched.
Comment 5 Alan Pevec 2014-07-10 10:03:55 UTC 
(In reply to Alan Pevec from comment #2)
> Please remove that code then.

What Ihar said, "that code" := openstack_dashboard/openstack/common/rpc/
Comment 6 Matthias Runge 2014-07-16 09:42:00 UTC 
We have tested on a system set up by QE. (puddle from May 28th). I haven't seen any issue, esp. no issue with swift. As far as I saw, swiftclient integration is the only part using bits from openstack_dashboard/openstack/common
Comment 7 Lon Hohberger 2014-08-04 17:39:09 UTC 
It sounds like this is a clean-up that doesn't cause functional issues with Horizon.  As a consequence, I am changing the bug synopsis.
Comment 8 Scott Lewis 2015-06-19 17:57:38 UTC 
This bug has been closed because OSP-4 has reached its end of life: https://rhn.redhat.com/errata/RHSA-2015-1127.html
Note You need to log in before you can comment on or make changes to this bug.