Bug 1120712
| Summary: | On data domain creation rest-api should use format V3 by default | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Federico Simoncelli <fsimonce> |
| Component: | ovirt-engine | Assignee: | Allon Mureinik <amureini> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Raz Tamir <ratamir> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.5.0 | CC: | amureini, bazulay, ecohen, gklein, iheim, juan.hernandez, lpeer, oramraz, rbalakri, Rhev-m-bugs, scohen, tnisan, yeylon |
| Target Milestone: | --- | ||
| Target Release: | 3.5.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | storage | ||
| Fixed In Version: | ovirt-3.5.0_rc1.1 | Doc Type: | Bug Fix |
| Doc Text: |
Cause:
Previously, when creating a storage domain via REST API, if the <storage_format> is not specified, it's implicitly treated as V1.
Consequence:
V1 is deprecated, and once the domain is attached to any DC with compatibility level > 3.0, it's upgraded to V3. This is both time consuming and error-prone.
Fix:
The default for DATA DOMAIN has been changed, and when creating a storage domain via REST API, if the <storage_format> is not specified, it's implicitly treated as V3.
Result:
Behavior change, as described above.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | Bug | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1118349, 1142923, 1156165, 1242092 | ||
The RESTAPI doesn't decide what is the default format, it just passes to the backend what the caller provided. If the caller doesn't provide a value for the format then it will have the default value, as assigned in the constructor of the StorageDomainStatic class. Before changing the default please take into consideration the possible backwards compatibility issues. (In reply to Juan Hernández from comment #1) > Before changing the default please take into consideration the possible > backwards compatibility issues. Changing the ctor is small-change. As you said - the issue is backwards compatibility. The main issue I'm concerned about is creating ISO and Export domains, which, AFAIK, should be V1. Is this bug really worth the risk? (In reply to Allon Mureinik from comment #2) > The main issue I'm concerned about is creating ISO and Export domains, > which, AFAIK, should be V1. > Is this bug really worth the risk? I really don't know what are the effects of changing the default, and to be on the safe side I'd say it isn't worth the risk. (In reply to Juan Hernández from comment #3) > (In reply to Allon Mureinik from comment #2) > > The main issue I'm concerned about is creating ISO and Export domains, > > which, AFAIK, should be V1. > > Is this bug really worth the risk? > > I really don't know what are the effects of changing the default, and to be > on the safe side I'd say it isn't worth the risk. Maybe it's not clear what happens. By default (when not specified) you create a storage domain V1 and as soon as you attach it to a data-center >= 3.1 it gets updated. Version V1 is obsolete and shouldn't be used. To make a comparison this is like formatting a device with ext2 and then convert it to ext3 and ext4. If you really want a V1 data domain (discouraged) you can still do it explicitly requesting the format. Moreover when we'll drop 3.0 we'll just have data domains V3 so sooner or later this has to change. Verified on - ovirt-engine-3.5.0-0.0.master.20140821064931.gitb794d66.el6.noarch Response body (REST api): ... <storage_format>v3</storage_format> ... Also in webadmin storage format is V3 Please supply doc text RHEV-M 3.5.0 has been released, closing this bug. RHEV-M 3.5.0 has been released, closing this bug. |
Description of problem: It is time to switch the data domain default version to V3 on creation. WebAdmin is already prompting V3 as default but REST-API it is not yet using V3 when the format is not specified, e.g.: <storage_domain> <name>iscsi_0</name> <type>data</type> <storage> <type>iscsi</type> <logical_unit id="..."> <port>3260</port> <target>...</target> <address>...</address> </logical_unit> </storage> <host> <name>...</name> </host> </storage_domain> Version-Release number of selected component (if applicable): ovirt-engine-3.5.0-0.0.master.20140629172257.git0b16ed7.el6.noarch How reproducible: 100% Steps to Reproduce: 1. Create a data storage domain using rest-api and not specifying the storage_format Actual results: Created domain is V1 Expected results: Created domain should be V3 Additional info: This should be tested both for file and block domains.