Description of problem:
It is time to switch the data domain default version to V3 on creation. WebAdmin is already prompting V3 as default but REST-API it is not yet using V3 when the format is not specified, e.g.:
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Create a data storage domain using rest-api and not specifying the storage_format
Created domain is V1
Created domain should be V3
This should be tested both for file and block domains.
The RESTAPI doesn't decide what is the default format, it just passes to the backend what the caller provided. If the caller doesn't provide a value for the format then it will have the default value, as assigned in the constructor of the StorageDomainStatic class.
Before changing the default please take into consideration the possible backwards compatibility issues.
(In reply to Juan Hernández from comment #1)
> Before changing the default please take into consideration the possible
> backwards compatibility issues.
Changing the ctor is small-change. As you said - the issue is backwards compatibility.
The main issue I'm concerned about is creating ISO and Export domains, which, AFAIK, should be V1.
Is this bug really worth the risk?
(In reply to Allon Mureinik from comment #2)
> The main issue I'm concerned about is creating ISO and Export domains,
> which, AFAIK, should be V1.
> Is this bug really worth the risk?
I really don't know what are the effects of changing the default, and to be on the safe side I'd say it isn't worth the risk.
(In reply to Juan Hernández from comment #3)
> (In reply to Allon Mureinik from comment #2)
> > The main issue I'm concerned about is creating ISO and Export domains,
> > which, AFAIK, should be V1.
> > Is this bug really worth the risk?
> I really don't know what are the effects of changing the default, and to be
> on the safe side I'd say it isn't worth the risk.
Maybe it's not clear what happens. By default (when not specified) you create a storage domain V1 and as soon as you attach it to a data-center >= 3.1 it gets updated.
Version V1 is obsolete and shouldn't be used. To make a comparison this is like formatting a device with ext2 and then convert it to ext3 and ext4.
If you really want a V1 data domain (discouraged) you can still do it explicitly requesting the format.
Moreover when we'll drop 3.0 we'll just have data domains V3 so sooner or later this has to change.
Verified on - ovirt-engine-3.5.0-0.0.master.20140821064931.gitb794d66.el6.noarch
Response body (REST api):
Also in webadmin storage format is V3
Please supply doc text
RHEV-M 3.5.0 has been released, closing this bug.