Bug 1121206

Summary:	oo-accept-node does not validate that EXTERNAL_ETH_DEV has a globally scoped IPv4 addres
Product:	OKD	Reporter:	Miciah Dashiel Butler Masters <mmasters>
Component:	Containers	Assignee:	Jhon Honce <jhonce>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	2.x	CC:	bmeng, jokerman, libra-bugs, libra-onpremise-devel, mmccomas, wzheng
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1121203	Environment:
Last Closed:	2014-10-10 00:46:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1121203

Description Miciah Dashiel Butler Masters 2014-07-18 16:01:29 UTC

+++ This bug was initially created as a clone of Bug #1121203 +++

Description of problem:

oo-iptables-port-proxy requires that EXTERNAL_ETH_DEV be set to a network interface that has a globally scoped IPv4 address.  oo-accept-node does not check that this requirement is met.


How reproducible:

Completely.


Steps to Reproduce:

1. Install an OpenShift Enterprise PaaS with 1 node.

2. Set EXTERNAL_ETH_DEV=lo in /etc/openshift/node.conf on the node in Step 1.

3. Run oo-accept-node.


Actual results:

oo-accept-node does not complain that the network interface specified by EXTERNAL_ETH_DEV does not have a globally scoped IPv4 address.


Expected results:

oo-accept-node should warn about the problem.


Additional info:

See bug 1121195.

Comment 1 Miciah Dashiel Butler Masters 2014-07-18 16:10:09 UTC

PR: https://github.com/openshift/origin-server/pull/5623

Comment 2 openshift-github-bot 2014-07-22 17:10:09 UTC

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/9a83c88dd32bfd5ad9275387c20ceb7a2ed86fa5
oo-accept-node: Add check_ext_net_dev_addr

Add check_ext_net_dev_addr to oo-accept-node to check that the network
interface specified by EXTERNAL_ETH_DEV in /etc/openshift/node.conf has
a globally scoped IPv4 address (if it does not, oo-iptables-port-proxy
will fail).

This commit fixes bug 1121206.

Comment 3 Wenjing Zheng 2014-07-23 03:24:07 UTC

Verified on devenv_4996, "oo-accept-node" returns correct error warning:
[root@ip-10-69-151-57 ~]# oo-accept-node
FAIL: SEVERE: lo has no globally scoped IPv4 address
FAIL: tc htb qdisc not configured
2 ERRORS