Bug 1122176
| Summary: | Review Request: kubernetes - Kubernetes container management | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Colin Walters <walters> |
| Component: | Package Review | Assignee: | Lokesh Mandvekar <lsm5> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jchaloup, lsm5, lsm5, package-review, tstclair |
| Target Milestone: | --- | Flags: | lsm5:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | NotReady | ||
| Fixed In Version: | kubernetes-0.9.1-0.2.git3623a01.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-11-01 17:05:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1140495, 1141807, 1141817, 1141822, 1141830, 1141841, 1141861, 1141864, 1141872, 1141875, 1141880, 1141887, 1141892, 1141896, 1142398, 1142399 | ||
| Bug Blocks: | |||
|
Description
Colin Walters
2014-07-22 17:23:42 UTC
This is a *work in progress*. Submitting the review request as I continue work on de-bundling so that people can try out the packages. Needs a newer version of go-dockerclient, built: http://pkgs.fedoraproject.org/cgit/golang-github-fsouza-go-dockerclient.git/commit/?id=90a714d2538edba7ea2735c20c862b464c14f53b We may need to split the cadvisor client library from the upstream code. I'll take this for review, unless there's another volunteer already :) Hope did not forget any package. Jan, Re: fsouza-go-dockerclient review: Bug 1085840 :) Ahh, Lokesh :), thanks, bugzilla does not search for closed bugs, my bad. (In reply to Jan Chaloupka from comment #9) > Ahh, Lokesh :), thanks, bugzilla does not search for closed bugs, my bad. yup, the default search box does not, but the 'Search' item on top will allow you to look for closed bugs too. Spec URL: https://jchaloup.fedorapeople.org/reviews/kubernetes/kubernetes.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/kubernetes/kubernetes-0.3-0.1.git88fdb65.fc21.src.rpm Koji: building on my local machine, not in koji due to dependency on cadvisor (already waiting for SCM) %{_bindir}/*
%{_unitdir}/*.service
%{_datadir}/bash-completion/completions/*
I suspect this will end up owning all files in these dirs. Better to own only those files which this package installs.
BuildRequires: gcc ... this isn't needed. koji uses gcc automatically.
Patch1 probably isn't needed in this anymore since the deps have been packaged already. Also, if the patch can be removed, we could replace %autosetup with %setup and not need BuildRequires: git.
Spec URL: https://jchaloup.fedorapeople.org/reviews/kubernetes/kubernetes.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/kubernetes/kubernetes-0.3-0.2.git88fdb65.fc21.src.rpm $ rpmlint kubernetes.spec /root/rpmbuild/SRPMS/kubernetes-0.3-0.2.git88fdb65.fc21.src.rpm /root/rpmbuild/RPMS/x86_64/kubernetes-0.3-0.2.git88fdb65.fc21.x86_64.rpm kubernetes.spec:248: W: macro-in-%changelog %check kubernetes.spec:110: W: mixed-use-of-spaces-and-tabs (spaces: line 110, tab: line 2) kubernetes.src: W: name-repeated-in-summary C Kubernetes kubernetes.src:248: W: macro-in-%changelog %check kubernetes.src:110: W: mixed-use-of-spaces-and-tabs (spaces: line 110, tab: line 2) kubernetes.x86_64: W: name-repeated-in-summary C Kubernetes kubernetes.x86_64: W: unstripped-binary-or-object /usr/bin/kube-proxy kubernetes.x86_64: E: statically-linked-binary /usr/bin/kube-proxy kubernetes.x86_64: W: unstripped-binary-or-object /usr/bin/kubelet kubernetes.x86_64: E: statically-linked-binary /usr/bin/kubelet kubernetes.x86_64: W: unstripped-binary-or-object /usr/bin/kubecfg kubernetes.x86_64: E: statically-linked-binary /usr/bin/kubecfg kubernetes.x86_64: W: unstripped-binary-or-object /usr/bin/kube-scheduler kubernetes.x86_64: E: statically-linked-binary /usr/bin/kube-scheduler kubernetes.x86_64: W: unstripped-binary-or-object /usr/bin/kube-controller-manager kubernetes.x86_64: E: statically-linked-binary /usr/bin/kube-controller-manager kubernetes.x86_64: W: unstripped-binary-or-object /usr/bin/kube-apiserver kubernetes.x86_64: E: statically-linked-binary /usr/bin/kube-apiserver kubernetes.x86_64: E: wrong-script-interpreter /usr/share/bash-completion/completions/kubecfg bash kubernetes.x86_64: W: no-manual-page-for-binary kube-scheduler kubernetes.x86_64: W: no-manual-page-for-binary kube-apiserver kubernetes.x86_64: W: no-manual-page-for-binary kube-proxy kubernetes.x86_64: W: no-manual-page-for-binary kubelet kubernetes.x86_64: W: no-manual-page-for-binary kubecfg kubernetes.x86_64: W: no-manual-page-for-binary kube-controller-manager 2 packages and 1 specfiles checked; 7 errors, 18 warnings. After fixing summary and bash-completion: kubernetes.spec:248: W: macro-in-%changelog %check kubernetes.spec:110: W: mixed-use-of-spaces-and-tabs (spaces: line 110, tab: line 2) kubernetes.src:248: W: macro-in-%changelog %check kubernetes.src:110: W: mixed-use-of-spaces-and-tabs (spaces: line 110, tab: line 2) kubernetes.x86_64: W: unstripped-binary-or-object /usr/bin/kube-proxy kubernetes.x86_64: E: statically-linked-binary /usr/bin/kube-proxy kubernetes.x86_64: W: unstripped-binary-or-object /usr/bin/kubelet kubernetes.x86_64: E: statically-linked-binary /usr/bin/kubelet kubernetes.x86_64: W: unstripped-binary-or-object /usr/bin/kubecfg kubernetes.x86_64: E: statically-linked-binary /usr/bin/kubecfg kubernetes.x86_64: W: unstripped-binary-or-object /usr/bin/kube-scheduler kubernetes.x86_64: E: statically-linked-binary /usr/bin/kube-scheduler kubernetes.x86_64: W: unstripped-binary-or-object /usr/bin/kube-controller-manager kubernetes.x86_64: E: statically-linked-binary /usr/bin/kube-controller-manager kubernetes.x86_64: W: unstripped-binary-or-object /usr/bin/kube-apiserver kubernetes.x86_64: E: statically-linked-binary /usr/bin/kube-apiserver kubernetes.x86_64: W: no-manual-page-for-binary kube-scheduler kubernetes.x86_64: W: no-manual-page-for-binary kube-apiserver kubernetes.x86_64: W: no-manual-page-for-binary kube-proxy kubernetes.x86_64: W: no-manual-page-for-binary kubelet kubernetes.x86_64: W: no-manual-page-for-binary kubecfg kubernetes.x86_64: W: no-manual-page-for-binary kube-controller-manager Changelog: kubernetes.spec:248: W: macro-in-%changelog %check kubernetes.spec:110: W: mixed-use-of-spaces-and-tabs (spaces: line 110, tab: line 2) resolved. Updated files: Spec URL: https://jchaloup.fedorapeople.org/reviews/kubernetes/kubernetes.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/kubernetes/kubernetes-0.3-0.2.git88fdb65.fc21.src.rpm -golang binaries are statically linked, so errors can be ignored https://fedoraproject.org/wiki/PackagingDrafts/Go -Package summary updated. -Bash completion error corrected. -files installed in %{_bindir} and %{_unitdir} and completions/ explicitly listed. -LICENSE installed. Package approved (subject to a final successful koji build). Go ahead with SCM request, but please post a koji scratch build url before actually building :) TODO: preferable to have a -docs subpackage installing documentation from the docs/ dir. Or include them in the main package itself if docs aren't too huge. New Package SCM Request ======================= Package Name: kubernetes Short Description: Kubernetes container management Upstream URL: https://github.com/GoogleCloudPlatform/kubernetes/ Owners: jchaloup lsm5 vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig Git done (by process-git-requests). kubernetes-0.3-0.2.git88fdb65.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/kubernetes-0.3-0.2.git88fdb65.fc21 kubernetes-0.3-0.2.git88fdb65.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/kubernetes-0.3-0.2.git88fdb65.fc20 kubernetes-0.3-0.2.git88fdb65.fc21 has been pushed to the Fedora 21 testing repository. kubernetes-0.4-0.1.gitb011263.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/kubernetes-0.4-0.1.gitb011263.fc20 kubernetes-0.4-0.6.gite46af6e.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/kubernetes-0.4-0.6.gite46af6e.fc20 kubernetes-0.4+-0.9.git8e1d416.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/kubernetes-0.4+-0.9.git8e1d416.fc20 kubernetes-0.3-0.2.git88fdb65.fc21 has been pushed to the Fedora 21 stable repository. kubernetes-0.5-105.0.git3f74a1e.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/kubernetes-0.5-105.0.git3f74a1e.fc20 kubernetes-0.6-4.0.git993ef88.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/kubernetes-0.6-4.0.git993ef88.fc20 Eric, looks like this bug is still waiting for a stable f20 rpm. I guess we could push kubernetes-0.6-4.0.git993ef88.fc20 to stable (with karma or otherwise) and get this bug out of the way :) We also need el6 build, right, or don't we? (we can pretty much ignore f19 now) Hi, el6 build can be tricky as not all the dependecies are in stable. Besides, el6 has no systemd so the service files needs to be rewritten first. kubernetes-0.6-4.0.git993ef88.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. kubernetes-0.9.1-0.1.git3623a01.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/kubernetes-0.9.1-0.1.git3623a01.fc20 kubernetes-0.9.1-0.1.git3623a01.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/kubernetes-0.9.1-0.1.git3623a01.fc21 kubernetes-0.9.1-0.2.git3623a01.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/kubernetes-0.9.1-0.2.git3623a01.fc21 kubernetes-0.9.1-0.2.git3623a01.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/kubernetes-0.9.1-0.2.git3623a01.fc20 kubernetes-0.9.1-0.2.git3623a01.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. kubernetes-0.9.1-0.2.git3623a01.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |