Spec URL: https://raw.githubusercontent.com/projectatomic/kubernetes-package/master/deps/cadvisor/cadvisor.spec FAS username: jchaloup repo: https://github.com/projectatomic/kubernetes-package/tree/master/deps/cadvisor
Please add the summary and description to your review request, see http://fedoraproject.org/wiki/Package_Review_Process
Spec URL: https://jchaloup.fedorapeople.org/reviews/cadvisor/cadvisor.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/cadvisor/cadvisor-0.3.0-0.2.git9d158c3d.fc21.src.rpm Description: Analyzes resource usage and performance characteristics of running containers $ rpmlint /root/rpmbuild/SRPMS/cadvisor-0.3.0-0.2.git9d158c3d.fc21.src.rpm /root/rpmbuild/RPMS/x86_64/cadvisor-0.3.0-0.2.git9d158c3d.fc21.x86_64.rpm /root/rpmbuild/RPMS/x86_64/cadvisor-devel-0.3.0-0.2.git9d158c3d.fc21.x86_64.rpm cadvisor.spec cadvisor.src: W: spelling-error %description -l en_US lmctfy cadvisor.src: W: spelling-error %description -l en_US libcontainer -> lib container, lib-container, containerize cadvisor.src: W: spelling-error %description -l en_US execdriver -> exec driver, exec-driver, cabdriver cadvisor.src: W: spelling-error %description -l en_US backends -> back ends, back-ends, backhands cadvisor.src: W: spelling-error %description -l en_US lmctfy's -> olfactory's cadvisor.src: W: invalid-license ASL2.0 cadvisor.src:114: W: rpm-buildroot-usage %build export GOPATH=$(pwd)/_build:%{buildroot}%{gopath}:%{gopath} cadvisor.x86_64: W: spelling-error %description -l en_US lmctfy cadvisor.x86_64: W: spelling-error %description -l en_US libcontainer -> lib container, lib-container, containerize cadvisor.x86_64: W: spelling-error %description -l en_US execdriver -> exec driver, exec-driver, cabdriver cadvisor.x86_64: W: spelling-error %description -l en_US backends -> back ends, back-ends, backhands cadvisor.x86_64: W: spelling-error %description -l en_US lmctfy's -> olfactory's cadvisor.x86_64: W: invalid-license ASL2.0 cadvisor.x86_64: W: unstripped-binary-or-object /usr/bin/cadvisor cadvisor.x86_64: E: non-readable /etc/sysconfig/cadvisor 0660L cadvisor.x86_64: W: no-manual-page-for-binary cadvisor cadvisor-devel.x86_64: W: spelling-error %description -l en_US lmctfy cadvisor-devel.x86_64: W: spelling-error %description -l en_US execdriver -> exec driver, exec-driver, cabdriver cadvisor-devel.x86_64: W: spelling-error %description -l en_US backends -> back ends, back-ends, backhands cadvisor-devel.x86_64: W: spelling-error %description -l en_US lmctfy's -> olfactory's cadvisor-devel.x86_64: W: invalid-license ASL2.0 cadvisor.spec:114: W: rpm-buildroot-usage %build export GOPATH=$(pwd)/_build:%{buildroot}%{gopath}:%{gopath} 3 packages and 1 specfiles checked; 1 errors, 21 warnings. Initial commit by Adam Miller, continued by Eric Paris Koji: Unfortunatelly, this build depends on more bzs. If needed, please build locally. On my machine (x86_64), it builds sucesfully.
Changes applied Spec URL: https://jchaloup.fedorapeople.org/reviews/cadvisor/cadvisor.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/cadvisor/cadvisor-0.3.0-0.3.git9d158c3.fc21.src.rpm Koji: when all packages cadvisor depends on are in koji, right local build succesfull
Specfile complies with existing golang packaging draft guidelines. I'll approve this and we can go ahead with scm request, but please post a URL to a successful koji build once all deps are in koji/buildroot-override before pushing this to dist-git :)
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7717404
New Package SCM Request ======================= Package Name: cadvisor Short Description: Analyzes resource usage and performance characteristics of running containers Upstream URL: https://github.com/google/cadvisor Owners: jchaloup lsm5 vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig
Git done (by process-git-requests).
cadvisor-0.3.0-0.4.git9d158c3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/cadvisor-0.3.0-0.4.git9d158c3.fc20
cadvisor-0.3.0-0.4.git9d158c3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/cadvisor-0.3.0-0.4.git9d158c3.fc21
cadvisor-0.3.0-0.4.git9d158c3.fc20 has been pushed to the Fedora 20 testing repository.
cadvisor-0.3.0-0.4.git9d158c3.fc20 has been pushed to the Fedora 20 stable repository.
cadvisor-0.3.0-0.4.git9d158c3.fc21 has been pushed to the Fedora 21 stable repository.
cadvisor-0.6.2-0.1.git89088df.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/cadvisor-0.6.2-0.1.git89088df.fc20
cadvisor-0.6.2-0.1.git89088df.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/cadvisor-0.6.2-0.1.git89088df.fc21
cadvisor-0.6.2-0.1.git89088df.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
cadvisor-0.6.2-0.1.git89088df.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
cadvisor-0.6.2-0.3.git89088df.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/cadvisor-0.6.2-0.3.git89088df.fc22
cadvisor-0.6.2-0.3.git89088df.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/cadvisor-0.6.2-0.3.git89088df.fc21
cadvisor-0.10.1-0.1.gitef7dddf.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/cadvisor-0.10.1-0.1.gitef7dddf.fc22
cadvisor-0.10.1-0.1.gitef7dddf.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/cadvisor-0.10.1-0.1.gitef7dddf.fc21
cadvisor-0.10.1-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/cadvisor-0.10.1-2.fc22
cadvisor-0.10.1-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/cadvisor-0.10.1-2.fc21
cadvisor-0.13.0-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/cadvisor-0.13.0-1.fc22
cadvisor-0.13.0-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/cadvisor-0.13.0-1.fc21
cadvisor-0.13.0-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
cadvisor-0.13.0-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.