Bug 1125290

Summary: fence_virt can return 0 on failure
Product: Red Hat Enterprise Linux 6 Reporter: Jaroslav Kortus <jkortus>
Component: fence-virtAssignee: Ryan McCabe <rmccabe>
Status: CLOSED ERRATA QA Contact: cluster-qe <cluster-qe>
Severity: high Docs Contact:
Priority: high    
Version: 6.6CC: cluster-maint, jherrman, mgrac, mjuricek, rbalakri
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: fence-virt-0.2.3-19.el6 Doc Type: Bug Fix
Doc Text:
Previously, the fence-virt utility in some case incorrectly returned a zero exit code when it detected an error in processing a request. With this update, the static analysis errors that caused this problem have been fixed, and fence-virt now returns appropriate error codes if it detects an error.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2015-07-22 07:32:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Jaroslav Kortus 2014-07-31 13:50:01 UTC 
Description of problem:
fence_virt can return 0 even though it detected an error on processing the request

Version-Release number of selected component (if applicable):
fence-virt-0.2.3-18.el6.x86_64

How reproducible:
100%

Steps to Reproduce:
1. fence_virt -H xxxxx -t 1; echo $?
2.
3.

Actual results:
[root@virt-136 pengine]# fence_virt -H xxxxx -t 1; echo $?
vmchannel connect: Connection timed out
Failed to connect to 10.0.2.179:1229
0


Expected results:
[root@virt-136 pengine]# fence_virt -H xxxxx -t 1; echo $?
vmchannel connect: Connection timed out
Failed to connect to 10.0.2.179:1229
0 <-- non-zero exit code should be displayed here


Additional info:
Comment 2 Ryan McCabe 2014-09-15 15:16:29 UTC 
This has already been fixed upstream in commit

commit f7ccaa261a83505118b735067846f17bde12430c
Author: Lon Hohberger <lon@users.sourceforge.net>
Date:   Tue Sep 20 11:40:39 2011 -0400

    Fix static analysis errors
    
    Signed-off-by: Lon Hohberger <lon@users.sourceforge.net>
Comment 7 errata-xmlrpc 2015-07-22 07:32:37 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1401.html