Bug 1125917

Summary: The new added jvm parameters were not added to the exisitng zend apps
Product: OpenShift Online Reporter: Meng Bo <bmeng>
Component: ImageAssignee: Ben Parees <bparees>
Status: CLOSED NOTABUG QA Contact: libra bugs <libra-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 2.xCC: jokerman, mmccomas
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-01 12:31:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Meng Bo 2014-08-01 10:38:30 UTC
Description of problem:
According to trello card https://trello.com/c/YHgRD2fp/214-2-add-additional-jvm-heap-optimization-settings

There are 4 new jvm parameters were introduced in this sprint.

Check my old apps on STG, found the new params were not there.

[wordpress-bmeng1stg.stg.rhcloud.com 53da0bd2dbd93c3907000458]\> ps -ef |grep java
2759      93855      1  0 06:04 ?        00:00:00 /var/lib/openshift/53da0bd2dbd93c3907000458/zend/php-5.4/bin/watchdog -c /var/lib/openshift/53da0bd2dbd93c3907000458/zend/php-5.4/etc/watchdog-jb.ini -u 2759 -g 2759 -s java_daemon
2759      93857  93855  0 06:04 ?        00:00:00 /usr/bin/java -XX:+UseSerialGC -Xms20M -Xmx128M -Dzend.javamw.threads=20 -Dzend.javamw.ip=127.5.99.129 -Dzend.javamw.port=10001 -Dzend.javamw.log=0 -Dzend.javamw.logfile=/var/lib/openshift/53da0bd2dbd93c3907000458/zend/php-5.4/var/log/javamw.log com.zend.javamw.JavaServer
2759      95099  74172  0 06:05 pts/1    00:00:00 grep java

After check in the gear, I found the file zend/versions/6.1/configuration/user-files/etc/watchdog-jb.ini was updated, but the zend/php-5.4/etc/watchdog-jb.ini was not. And 2nd one should be used by the java process.

Version-Release number of selected component (if applicable):
STG (devenv-stage_939)

How reproducible:
always

Steps to Reproduce:
1. Create apps on STG
2. STG got upgraded 
3. Check the java process on old apps

Actual results:
The new added jvm parameters were not found in the old zend apps

Expected results:
The new params should be appended.

Additional info:
Content of the files:
# cat zend/php-5.4/etc/watchdog-jb.ini
zend_wd.tmp_dir=/var/lib/openshift/53da0bd2dbd93c3907000458/zend/php-5.4/tmp
zend_wd.process.java_daemon=/usr/bin/java -XX:+UseSerialGC -Xms20M -Xmx128M -Dzend.javamw.threads=20 -Dzend.javamw.ip=127.5.99.129 -Dzend.javamw.port=10001 -Dzend.javamw.log=0 -Dzend.javamw.logfile=/var/lib/openshift/53da0bd2dbd93c3907000458/zend/php-5.4/var/log/javamw.log com.zend.javamw.JavaServer
zend_wd.env.java_daemon=CLASSPATH=/var/lib/openshift/53da0bd2dbd93c3907000458/zend/php-5.4/bin/javamw.jar

# cat zend/versions/6.1/configuration/user-files/etc/watchdog-jb.ini
zend_wd.tmp_dir=/var/lib/openshift/53da0bd2dbd93c3907000458/zend/php-5.4/tmp
zend_wd.process.java_daemon=/usr/bin/java -XX:MinHeapFreeRatio=20 -XX:MaxHeapFreeRatio=40 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -Xms20M -Xmx128M -Dzend.javamw
.threads=20 -Dzend.javamw.ip=127.5.99.129 -Dzend.javamw.port=10001 -Dzend.javamw.log=0 -Dzend.javamw.logfile=/var/lib/openshift/53da0bd2dbd93c3907000458/zend/php-5.4/var/
log/javamw.log com.zend.javamw.JavaServer
zend_wd.env.java_daemon=CLASSPATH=/var/lib/openshift/53da0bd2dbd93c3907000458/zend/php-5.4/bin/javamw.jar

Comment 1 Ben Parees 2014-08-01 12:31:51 UTC
We decided not to do a migration of those parameters because the file is user editable and we did not want to risk modifying something a user had customized.