Bug 1127091
| Summary: | Review Request: perl-PerlIO-buffersize - Set the buffersize of a handle | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Holcapek <holcapek> |
| Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | lkundrak, package-review |
| Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-PerlIO-buffersize-0.001-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-08-16 00:26:04 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jan Holcapek
2014-08-06 06:53:09 UTC
Additional note: the reason why there is a patch that avoids (build) dependency to PerlIO::Layers (dont-use-perlio-layers.patch) is quite simple: because this module were not used anywhere (well, it was use-d, but the imported method was not called). Are you going to package it for EL5? (In reply to Christopher Meng from comment #2) > Are you going to package it for EL5? No (unless someone would be interested in having this package in EPEL 5). Fine.
Transient SPEC review:
1. Drop these:
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
rm -rf $RPM_BUILD_ROOT
find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
%clean
%defattr(-,root,root,-)
dist.ini
META.json
2. Fix the invalid changelog:
* Tue Aug 05 2014 holcapek 0.001-1
(In reply to Christopher Meng from comment #4) > Fine. > > Transient SPEC review: > > 1. Drop these: > > BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} > -n) > > rm -rf $RPM_BUILD_ROOT > > find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; > > %clean > > %defattr(-,root,root,-) > > dist.ini > > META.json > > 2. Fix the invalid changelog: > > * Tue Aug 05 2014 holcapek 0.001-1 Thanks. All's done. Taking for an official review. * Package named correctly * Source file matches upstream * Latest version used * License tag okay * License file included * License fine for fedora * SPEC file clean and legible * Builds in mock * Provides/Requires fine * Filelist ok * Proper compiler flags used APPROVED You should consider upstreaming the patch, or adding a comment clarifying why isn't the patch upstream. New Package SCM Request ======================= Package Name: perl-PerlIO-buffersize Short Description: Set the buffersize of a handle Upstream URL: http://search.cpan.org/dist/PerlIO-buffersize/ Owners: holcapek Branches: f19 f20 f21 el6 epel7 InitialCC: lkundrak Git done (by process-git-requests). perl-PerlIO-buffersize-0.001-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-PerlIO-buffersize-0.001-1.fc20 perl-PerlIO-buffersize-0.001-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-PerlIO-buffersize-0.001-1.fc19 perl-PerlIO-buffersize-0.001-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-PerlIO-buffersize-0.001-1.el6 perl-PerlIO-buffersize-0.001-1.el6 has been pushed to the Fedora EPEL 6 testing repository. perl-PerlIO-buffersize-0.001-1.fc19 has been pushed to the Fedora 19 stable repository. perl-PerlIO-buffersize-0.001-1.fc20 has been pushed to the Fedora 20 stable repository. perl-PerlIO-buffersize-0.001-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |