Spec URL: https://raw.githubusercontent.com/holcapek/perl-PerlIO-buffersize/master/perl-PerlIO-buffersize.spec SRPM URL: https://github.com/holcapek/perl-PerlIO-buffersize/raw/master/perl-PerlIO-buffersize-0.001-1.fc22.src.rpm Description: This module sets the buffer-size of a filehandle to an other value than the default. This can only be done before the handle is used, as once the buffer has been allocated it can not be changed. Fedora Account System Username: holcapek
Additional note: the reason why there is a patch that avoids (build) dependency to PerlIO::Layers (dont-use-perlio-layers.patch) is quite simple: because this module were not used anywhere (well, it was use-d, but the imported method was not called).
Are you going to package it for EL5?
(In reply to Christopher Meng from comment #2) > Are you going to package it for EL5? No (unless someone would be interested in having this package in EPEL 5).
Fine. Transient SPEC review: 1. Drop these: BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) rm -rf $RPM_BUILD_ROOT find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; %clean %defattr(-,root,root,-) dist.ini META.json 2. Fix the invalid changelog: * Tue Aug 05 2014 holcapek 0.001-1
(In reply to Christopher Meng from comment #4) > Fine. > > Transient SPEC review: > > 1. Drop these: > > BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} > -n) > > rm -rf $RPM_BUILD_ROOT > > find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; > > %clean > > %defattr(-,root,root,-) > > dist.ini > > META.json > > 2. Fix the invalid changelog: > > * Tue Aug 05 2014 holcapek 0.001-1 Thanks. All's done.
Taking for an official review.
* Package named correctly * Source file matches upstream * Latest version used * License tag okay * License file included * License fine for fedora * SPEC file clean and legible * Builds in mock * Provides/Requires fine * Filelist ok * Proper compiler flags used APPROVED
You should consider upstreaming the patch, or adding a comment clarifying why isn't the patch upstream.
New Package SCM Request ======================= Package Name: perl-PerlIO-buffersize Short Description: Set the buffersize of a handle Upstream URL: http://search.cpan.org/dist/PerlIO-buffersize/ Owners: holcapek Branches: f19 f20 f21 el6 epel7 InitialCC: lkundrak
Git done (by process-git-requests).
perl-PerlIO-buffersize-0.001-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-PerlIO-buffersize-0.001-1.fc20
perl-PerlIO-buffersize-0.001-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-PerlIO-buffersize-0.001-1.fc19
perl-PerlIO-buffersize-0.001-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-PerlIO-buffersize-0.001-1.el6
perl-PerlIO-buffersize-0.001-1.el6 has been pushed to the Fedora EPEL 6 testing repository.
perl-PerlIO-buffersize-0.001-1.fc19 has been pushed to the Fedora 19 stable repository.
perl-PerlIO-buffersize-0.001-1.fc20 has been pushed to the Fedora 20 stable repository.
perl-PerlIO-buffersize-0.001-1.el6 has been pushed to the Fedora EPEL 6 stable repository.