Bug 1127727
| Summary: | [Networks]>Empty Description should be part of Sorting, just like The Behavior in the sub-tab vNIC profiles | ||
|---|---|---|---|
| Product: | [Retired] oVirt | Reporter: | Michael Burman <mburman> |
| Component: | ovirt-engine-core | Assignee: | Ori Liel <oliel> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Michael Burman <mburman> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 3.5 | CC: | bazulay, bugs, ecohen, gklein, lsurette, mgoldboi, oourfali, rbalakri, sherold, yeylon, ylavi |
| Target Milestone: | --- | Keywords: | UserExperience |
| Target Release: | 3.6.0 | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | infra | ||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-11-04 13:56:01 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Infra | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michael Burman
2014-08-07 12:22:13 UTC
Known issue with tabs using the backend sorting mechanism, not sure if there's another bug open on this or not. not sure what the correct behavior is here: should empty values always be at the end (in this case, client sorting should be fixed) or should empty values be treated just like any other value and appear where it makes sense, i.e. at the beginning of the list for an ascending sorting order, at the end of the list for a descending sorting order (in this case, server sorting should be fixed and BZ need to be re-assigned to 'infra')? @Liz - do you recall if we ended up reaching a decision on whether sorting by a field that contains empty values should contain the empty values as part of the sort, or should empty values always be pushed to the end? @Einav - I think it makes sense for empty values to be included in the sorting in the case where the user might want to raise any empty values to the top of the list. (In reply to Liz from comment #4) > @Einav - I think it makes sense for empty values to be included in the > sorting in the case where the user might want to raise any empty values to > the top of the list. thanks, Liz. Per comment #5, moving to 'infra' (search should be changed to include empty values in the sort, rather than always pushing records with empty values to the end of the sorted list). patch posted: https://gerrit.ovirt.org/#/c/42546/ Eli enlightened me that this requirement seems to contradict with the requirement in: https://bugzilla.redhat.com/show_bug.cgi?id=962560 IMO either we want to consider empty values, or we don't, but whichever it is, it should apply to all tabs. Scott, what do you think? 'needinfo'ing Yaniv/Moran, that may be able to chime in on the question in Comment #7 as well (relevant for bug 1243444 too). Since Liz said that the correct ux here is to sort the nulls, if think we should go with that. Seems more correct to me as well, but not major issue as I see it. so need to simply include nulls as part of the sort; so if sort is ascending, nulls should be first; if sort is descending - nulls should be last. this should be modified in the search mechanism. solved by https://bugzilla.redhat.com/1243444 Verified on - 3.6.0-0.0.master.20150726172446.git65db93d.el6 oVirt 3.6.0 has been released on November 4th, 2015 and should fix this issue. If problems still persist, please open a new BZ and reference this one. |