Bug 1132305
| Summary: | option -k and -K should point out range of reasonable values against virsh command | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | zhengqin <zsong> |
| Component: | libvirt | Assignee: | Erik Skultety <eskultet> |
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 7.1 | CC: | dyuan, eskultet, mzhan, rbalakri, vivianzhang, zhwang, zpeng |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | libvirt-1.2.8-1.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-03-05 07:43:03 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Fixed upstream:
commit f284ee54bad3fc7e229a61228387d0c3d5172d61
Author: Erik Skultety <eskultet>
Date: Wed Aug 27 16:20:29 2014 +0200
virsh: fix keepalive error msg
resolves https://bugzilla.redhat.com/show_bug.cgi?id=1132305:
The error message for an out-of-range argument was confusing:
virsh -k 9999999999
error: option --k requires a positive numeric argument
After this patch, it is:
error: Invalid value for option -k
Signed-off-by: Eric Blake <eblake>
v1.2.8-rc1-11-gf284ee5
Verified with build libvirt-1.2.8-1.el7.x86_64: [root@rhel7-a1 ~]# virsh -k 9999999999 error: Invalid value for option -k [root@rhel7-a1 ~]# virsh -K 9999999999 error: Invalid value for option -K [root@rhel7-a1 ~]# virsh --keepalive-interval=9999999999 error: Invalid value for option --keepalive-interval [root@rhel7-a1 ~]# virsh --keepalive-count=9999999999 error: Invalid value for option --keepalive-count I can produce it on build libvirt-1.2.7-1.el7.x86_64
verify it on build
libvirt-1.2.8-9.el7.x86_64
# virsh -k 9999999999
error: Invalid value for option -k
[root@server ~]# virsh -K 99999999
Welcome to virsh, the virtualization interactive terminal.
Type: 'help' for help with commands
'quit' to quit
virsh # quit
[root@server ~]# virsh -K 9999999999
error: Invalid value for option -K
[root@server ~]# virsh -K -1
error: option -K requires a positive integer argument
[root@server ~]# virsh -k -1
error: option -k requires a positive integer argument
[root@server ~]# virsh -k a
error: Invalid value for option -k
[root@server ~]# virsh -k !
error: Invalid value for option -k
move to verified
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2015-0323.html |
Description of problem: Version-Release number of selected component (if applicable): libvirt-1.2.7-1.el7.x86_64 qemu-kvm-rhev-2.1.0-1.el7.x86_64 kernel-3.10.0-142.el7.x86_64 How reproducible: 100% Steps to Reproduce: 1. Here is man page: -k, --keepalive-interval INTERVAL Set an INTERVAL (in seconds) for sending keepalive messages to check whether connection to the server is still alive. Setting the interval to 0 disables client keepalive mechanism. -K, --keepalive-count COUNT Set a number of times keepalive message can be sent without getting an answer from the server without marking the connection dead. There is no effect to this setting in case the INTERVAL is set to 0. 2. Run the following command: [root@rhel7-b ~]# virsh -k 9999999999 error: option --k requires a positive numeric argument [root@rhel7-b ~]# virsh -K 9999999999 error: option --K requires a positive numeric argument Actual results: 1. 9999999999 is a positive numeric argument, but got error. Expected results: 1. man page should point out range of reasonable values. 2. Error info should follow man page.