RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1132305 - option -k and -K should point out range of reasonable values against virsh command
Summary: option -k and -K should point out range of reasonable values against virsh co...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.1
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Erik Skultety
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-08-21 06:25 UTC by zhengqin
Modified: 2015-03-05 07:43 UTC (History)
7 users (show)

Fixed In Version: libvirt-1.2.8-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-05 07:43:03 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:0323 0 normal SHIPPED_LIVE Low: libvirt security, bug fix, and enhancement update 2015-03-05 12:10:54 UTC

Description zhengqin 2014-08-21 06:25:20 UTC 
Description of problem:


Version-Release number of selected component (if applicable):
libvirt-1.2.7-1.el7.x86_64
qemu-kvm-rhev-2.1.0-1.el7.x86_64
kernel-3.10.0-142.el7.x86_64


How reproducible:
100%

Steps to Reproduce:
1. Here is man page:

    -k, --keepalive-interval INTERVAL
            Set an INTERVAL (in seconds) for sending keepalive messages
to check whether connection to the server is still alive. Setting the
interval to 0 disables client
            keepalive mechanism.

    -K, --keepalive-count COUNT
            Set a number of times keepalive message can be sent without
getting an answer from the server without marking the connection dead.
There is no effect to this
            setting in case the INTERVAL is set to 0.


2. Run the following command:

[root@rhel7-b ~]# virsh -k 9999999999
error: option --k requires a positive numeric argument
[root@rhel7-b ~]# virsh -K 9999999999
error: option --K requires a positive numeric argument

Actual results:
1. 9999999999 is a positive numeric argument, but got error.

Expected results:
1. man page should point out range of reasonable values.

2. Error info should follow man page.
Comment 1 Erik Skultety 2014-08-28 06:49:15 UTC 
Fixed upstream:

commit f284ee54bad3fc7e229a61228387d0c3d5172d61
Author: Erik Skultety <eskultet>
Date:   Wed Aug 27 16:20:29 2014 +0200

    virsh: fix keepalive error msg
    
    resolves https://bugzilla.redhat.com/show_bug.cgi?id=1132305:
    
    The error message for an out-of-range argument was confusing:
    
    virsh -k 9999999999
    error: option --k requires a positive numeric argument
    
    After this patch, it is:
    
    error: Invalid value for option -k
    
    Signed-off-by: Eric Blake <eblake>

v1.2.8-rc1-11-gf284ee5
Comment 3 zhengqin 2014-09-10 05:16:16 UTC 
Verified with build libvirt-1.2.8-1.el7.x86_64:

[root@rhel7-a1 ~]# virsh -k 9999999999
error: Invalid value for option -k
[root@rhel7-a1 ~]# virsh -K 9999999999
error: Invalid value for option -K
[root@rhel7-a1 ~]# virsh --keepalive-interval=9999999999
error: Invalid value for option --keepalive-interval
[root@rhel7-a1 ~]# virsh --keepalive-count=9999999999
error: Invalid value for option --keepalive-count
Comment 5 vivian zhang 2014-11-28 07:28:07 UTC 
I can produce it on build libvirt-1.2.7-1.el7.x86_64

verify it on build
libvirt-1.2.8-9.el7.x86_64

# virsh -k 9999999999
error: Invalid value for option -k
[root@server ~]# virsh -K 99999999
Welcome to virsh, the virtualization interactive terminal.

Type:  'help' for help with commands
       'quit' to quit

virsh # quit


[root@server ~]# virsh -K 9999999999
error: Invalid value for option -K
[root@server ~]# virsh -K -1
error: option -K requires a positive integer argument
[root@server ~]# virsh -k -1
error: option -k requires a positive integer argument
[root@server ~]# virsh -k a
error: Invalid value for option -k
[root@server ~]# virsh -k !
error: Invalid value for option -k

move to verified
Comment 7 errata-xmlrpc 2015-03-05 07:43:03 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0323.html
Note You need to log in before you can comment on or make changes to this bug.