Bug 1133198
| Summary: | Review Request: perl-Compress-LZ4 - Perl interface to the LZ4 compression library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Dick <ddick> |
| Component: | Package Review | Assignee: | Paul Howarth <paul> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, paul |
| Target Milestone: | --- | Flags: | paul:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Compress-LZ4-0.20-1.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-10-16 01:59:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
David Dick
2014-08-23 08:32:19 UTC
koji builds el6 at http://koji.fedoraproject.org/koji/taskinfo?taskID=7441847 rawhide at http://koji.fedoraproject.org/koji/taskinfo?taskID=7441912 rpmlint output ============== 3 packages and 1 specfiles checked; 0 errors, 0 warnings. requires ======== libc.so.6 libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) liblz4.so.1 libperl.so.5.20 perl(:MODULE_COMPAT_5.20.1) perl(Exporter) perl(XSLoader) perl(strict) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 rtld(GNU_HASH) provides ======== perl(Compress::LZ4) = 0.20 perl-Compress-LZ4 = 0.20-1.fc22 perl-Compress-LZ4(x86-32) = 0.20-1.fc22 review checklist ================ - rpmlint clean - package and spec file naming OK - package meets guidelines - license is same as perl, matches upstream, fine for Fedora - spec file written in English and is legible - sources match upstream in content and timestamp - package builds OK in mock for Rawhide (x86_64) - buildreqs ok (but see below) - no locales, devel files, sub-packages to worry about - lz4 library properly unbundled - package is not intended to be relocatable - file and directory ownership OK - no duplicate files - permissions are sane - macro usage is consistent - code, not content - no large docs, and other docs don't affect runtime - not a GUI app, no desktop file needed - filenames are all ASCII nits ==== The unbundling patch could also remove the bundled files from the MANIFEST to stop MakeMaker moaning about them being missing. Test suite uses perl(overload) (t/01_lz4.t:35). Test::More version requirement should really be 0.88 due to the use of done_testing in the test suite. Package is APPROVED. Thanks Paul! New Package SCM Request ======================= Package Name: perl-Compress-LZ4 Short Description: Perl interface to the LZ4 compression library Upstream URL: http://search.cpan.org/dist/Compress-LZ4/ Owners: ddick Branches: f20, f21, epel7, el6 InitialCC: perl-sig Git done (by process-git-requests). perl-Compress-LZ4-0.20-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Compress-LZ4-0.20-1.fc20 perl-Compress-LZ4-0.20-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-Compress-LZ4-0.20-1.fc21 perl-Compress-LZ4-0.20-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Compress-LZ4-0.20-1.el6 perl-Compress-LZ4-0.20-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-Compress-LZ4-0.20-1.el7 perl-Compress-LZ4-0.20-1.el6 has been pushed to the Fedora EPEL 6 testing repository. perl-Compress-LZ4-0.20-1.fc21 has been pushed to the Fedora 21 stable repository. perl-Compress-LZ4-0.20-1.fc20 has been pushed to the Fedora 20 stable repository. perl-Compress-LZ4-0.20-1.el6 has been pushed to the Fedora EPEL 6 stable repository. perl-Compress-LZ4-0.20-1.el7 has been pushed to the Fedora EPEL 7 stable repository. |