Bug 1133198 - Review Request: perl-Compress-LZ4 - Perl interface to the LZ4 compression library
Summary: Review Request: perl-Compress-LZ4 - Perl interface to the LZ4 compression lib...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Paul Howarth
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-08-23 08:32 UTC by David Dick
Modified: 2014-10-23 16:07 UTC (History)
2 users (show)

Fixed In Version: perl-Compress-LZ4-0.20-1.el7
Clone Of:
Environment:
Last Closed: 2014-10-16 01:59:18 UTC
Type: ---
Embargoed:
paul: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description David Dick 2014-08-23 08:32:19 UTC
Spec URL: http://ddick.fedorapeople.org/packages/perl-Compress-LZ4.spec
SRPM URL: http://ddick.fedorapeople.org/packages/perl-Compress-LZ4-0.20-1.fc20.src.rpm
Description: Perl interface to the LZ4 (de)compressor
Fedora Account System Username: ddick

Comment 2 Paul Howarth 2014-10-06 15:27:26 UTC
rpmlint output
==============
3 packages and 1 specfiles checked; 0 errors, 0 warnings.

requires
========
libc.so.6
libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.4)
liblz4.so.1
libperl.so.5.20
perl(:MODULE_COMPAT_5.20.1)
perl(Exporter)
perl(XSLoader)
perl(strict)
perl(warnings)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
rtld(GNU_HASH)

provides
========
perl(Compress::LZ4) = 0.20
perl-Compress-LZ4 = 0.20-1.fc22
perl-Compress-LZ4(x86-32) = 0.20-1.fc22

review checklist
================
- rpmlint clean
- package and spec file naming OK
- package meets guidelines
- license is same as perl, matches upstream, fine for Fedora
- spec file written in English and is legible
- sources match upstream in content and timestamp
- package builds OK in mock for Rawhide (x86_64)
- buildreqs ok (but see below)
- no locales, devel files, sub-packages to worry about
- lz4 library properly unbundled
- package is not intended to be relocatable
- file and directory ownership OK
- no duplicate files
- permissions are sane
- macro usage is consistent
- code, not content
- no large docs, and other docs don't affect runtime
- not a GUI app, no desktop file needed
- filenames are all ASCII

nits
====
The unbundling patch could also remove the bundled files from
the MANIFEST to stop MakeMaker moaning about them being missing.

Test suite uses perl(overload) (t/01_lz4.t:35).

Test::More version requirement should really be 0.88 due to the use of
done_testing in the test suite.


Package is APPROVED.

Comment 3 David Dick 2014-10-06 19:51:44 UTC
Thanks Paul!

New Package SCM Request
=======================
Package Name: perl-Compress-LZ4
Short Description: Perl interface to the LZ4 compression library
Upstream URL: http://search.cpan.org/dist/Compress-LZ4/
Owners: ddick
Branches: f20, f21, epel7, el6
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2014-10-07 12:07:05 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2014-10-07 19:33:24 UTC
perl-Compress-LZ4-0.20-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Compress-LZ4-0.20-1.fc20

Comment 6 Fedora Update System 2014-10-07 19:33:46 UTC
perl-Compress-LZ4-0.20-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-Compress-LZ4-0.20-1.fc21

Comment 7 Fedora Update System 2014-10-07 19:34:10 UTC
perl-Compress-LZ4-0.20-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-Compress-LZ4-0.20-1.el6

Comment 8 Fedora Update System 2014-10-07 19:34:36 UTC
perl-Compress-LZ4-0.20-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/perl-Compress-LZ4-0.20-1.el7

Comment 9 Fedora Update System 2014-10-08 00:43:11 UTC
perl-Compress-LZ4-0.20-1.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 10 Fedora Update System 2014-10-16 01:59:18 UTC
perl-Compress-LZ4-0.20-1.fc21 has been pushed to the Fedora 21 stable repository.

Comment 11 Fedora Update System 2014-10-17 08:39:21 UTC
perl-Compress-LZ4-0.20-1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 12 Fedora Update System 2014-10-23 16:06:45 UTC
perl-Compress-LZ4-0.20-1.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 13 Fedora Update System 2014-10-23 16:07:11 UTC
perl-Compress-LZ4-0.20-1.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.