Bug 1133890

Summary: Live deletion of a snapshot (live merge) is blocked(CDA) when attempting the removal from snapshot overview
Product: [Retired] oVirt Reporter: Ori Gofen <ogofen>
Component: ovirt-engine-webadminAssignee: Greg Padgett <gpadgett>
Status: CLOSED CURRENTRELEASE QA Contact: Kevin Alon Goldblatt <kgoldbla>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.5CC: acanan, amureini, bugs, derez, ecohen, gklein, kgoldbla, mgoldboi, ogofen, rbalakri, tnisan, yeylon, ylavi
Target Milestone: ---   
Target Release: 3.5.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: storage
Fixed In Version: ovirt-3.5.1_rc1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1171832 (view as bug list) Environment:
Last Closed: 2015-04-29 06:16:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1196049    
Bug Blocks: 1171832, 1193058, 1196662, 1197441    
Attachments:
Description Flags
vdsm+engine logs none

Description Ori Gofen 2014-08-26 11:49:35 UTC 
Description of problem:

Live merge is blocked with CanDoAction to the attempts to remove a single snapshot from disk via snapshot overview feature.
This operation should be allowed due to the fact,Live merge operates on disk's volume, http://www.ovirt.org/Features/Live_Merge#Summary , thus, supports the live deletion of a single snapshot.

Version-Release number of selected component (if applicable):
rc1.1

How reproducible:
100%

Steps to Reproduce:
1.have vm+disk + snapshot
2.run vm and attempt to remove the disk's snapshot from snapshot overview tab

Actual results:
operation is blocked with CDA

Expected results:
operation should be allowed and successful

Additional info:
Comment 1 Allon Mureinik 2014-08-26 16:47:14 UTC 
Ori, please add the log.
Comment 2 Greg Padgett 2014-08-26 18:29:04 UTC 
I've reproduced this, assuming it's this error from the Storage > Disk Snapshots:

2014-08-26 14:16:53,407 WARN  [org.ovirt.engine.core.bll.RemoveDiskSnapshotsCommand] (http--0.0.0.0-8080-1) [f58e694] CanDoAction of action RemoveDiskSnapshots failed. Reasons:VAR__ACTION__REMOVE,VAR__TYPE__DISK__SNAPSHOT,ACTION_TYPE_FAILED_VM_IS_NOT_DOWN
Comment 3 Greg Padgett 2014-08-27 17:55:58 UTC 
Turns out that not only is this blocked, but lacks implementation as well.  The command used to remove snapshots from here is different than from the VM Disk tab, and will need to be branched for Live Merge.  I'm working on it, but it's not the small change to CDA I was hoping for.
Comment 4 Ori Gofen 2014-09-01 07:09:30 UTC 
Created attachment 933255 [details]
vdsm+engine logs

logs attached as asked.

2014-09-01 10:06:07,922 WARN  [org.ovirt.engine.core.bll.RemoveDiskSnapshotsCommand] (ajp--127.0.0.1-8702-10) [329fe6e1] CanDoAction of action RemoveDiskSnapshots failed. Reasons:VAR__ACTION__REMOVE,VAR__TYPE__DISK__SNAPSHOT,ACTION_TYPE_FAILED_VM_IS_NOT_DOWN
2014-09-01 10:06:07,930 INFO  [org.ovirt.engine.core.bll.RemoveDiskSnapshotsCommand] (ajp--127.0.0.1-8702-10) [329fe6e1] Lock freed to object EngineLock [exclusiveLocks= key: 05af808b-0ee0-49cb-94dc-1028dbb13082 value: DISK
, sharedLocks= ]
2014-09-01 10:06:23,982 INFO  [org.ovirt.engine.core.bll.RemoveDiskSnapshotsCommand] (ajp--127.0.0.1-8702-2) [42f295a8] Lock Acquired to object EngineLock [exclusiveLocks= key: 05af808b-0ee0-49cb-94dc-1028dbb13082 value: DISK
, sharedLocks= ]
2014-09-01 10:06:23,994 WARN  [org.ovirt.engine.core.bll.RemoveDiskSnapshotsCommand] (ajp--127.0.0.1-8702-2) [42f295a8] CanDoAction of action RemoveDiskSnapshots failed. Reasons:VAR__ACTION__REMOVE,VAR__TYPE__DISK__SNAPSHOT,ACTION_TYPE_FAILED_VM_IS_NOT_DOWN
2014-09-01 10:06:24,000 INFO  [org.ovirt.engine.core.bll.RemoveDiskSnapshotsCommand] (ajp--127.0.0.1-8702-2) [42f295a8] Lock freed to object EngineLock [exclusiveLocks= key: 05af808b-0ee0-49cb-94dc-1028dbb13082 value: DISK
, sharedLocks= ]
2014-09-01 10:06:24,657 INFO  [org.ovirt.engine.core.bll.OvfDataUpdater] (DefaultQuartzScheduler_Worker-11) Attempting to update VMs/Templates Ovf.
2014-09-01 10:06:31,135 INFO  [org.ovirt.engine.core.bll.RemoveDiskSnapshotsCommand] (ajp--127.0.0.1-8702-4) [5cfe6181] Lock Acquired to object EngineLock [exclusiveLocks= key: 05af808b-0ee0-49cb-94dc-1028dbb13082 value: DISK
, sharedLocks= ]
2014-09-01 10:06:31,146 WARN  [org.ovirt.engine.core.bll.RemoveDiskSnapshotsCommand] (ajp--127.0.0.1-8702-4) [5cfe6181] CanDoAction of action RemoveDiskSnapshots failed. Reasons:VAR__ACTION__REMOVE,VAR__TYPE__DISK__SNAPSHOT,ACTION_TYPE_FAILED_VM_IS_NOT_DOWN
2014-09-01 10:06:31,152 INFO  [org.ovirt.engine.core.bll.RemoveDiskSnapshotsCommand] (ajp--127.0.0.1-8702-4) [5cfe6181] Lock freed to object EngineLock [exclusiveLocks= key: 05af808b-0ee0-49cb-94dc-1028dbb13082 value: DISK
, sharedLocks= ]
Comment 5 Sandro Bonazzola 2015-01-15 14:14:52 UTC 
This is an automated message: 
This bug should be fixed in oVirt 3.5.1 RC1, moving to QA
Comment 6 Sandro Bonazzola 2015-01-21 16:02:39 UTC 
oVirt 3.5.1 has been released. If problems still persist, please make note of it in this bug report.
Comment 7 Eyal Edri 2015-02-26 12:31:59 UTC 
this ovirt bug was fixed during 3.5.1 cycle and is included in the build, and therefore should be verified.
Comment 8 Aharon Canan 2015-03-30 08:36:40 UTC 
Already verified downstream 
https://bugzilla.redhat.com/show_bug.cgi?id=1177138
Comment 9 Eyal Edri 2015-04-29 06:16:58 UTC 
ovirt 3.5.2 was GA'd. closing current release.