Bug 1171832 - Live deletion of a snapshot (live merge) is blocked(CDA) when attempting the removal from snapshot overview
Summary: Live deletion of a snapshot (live merge) is blocked(CDA) when attempting the ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.5.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-3.6.0-rc
: 3.6.0
Assignee: Greg Padgett
QA Contact: Kevin Alon Goldblatt
URL:
Whiteboard:
Depends On: 1133890
Blocks: 1177138
TreeView+ depends on / blocked
 
Reported: 2014-12-08 17:25 UTC by Greg Padgett
Modified: 2016-03-10 12:00 UTC (History)
15 users (show)

Fixed In Version: ovirt-engine-3.6.0_qa1
Doc Type: Bug Fix
Doc Text:
Clone Of: 1133890
: 1177138 (view as bug list)
Environment:
Last Closed:
oVirt Team: Storage
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 32338 0 master MERGED core: Enable Live Merge in Snapshots Overview 2020-07-15 16:45:15 UTC
oVirt gerrit 36001 0 None MERGED core: Enable Live Merge in Snapshots Overview 2020-07-15 16:45:15 UTC

Description Greg Padgett 2014-12-08 17:25:43 UTC
+++ This bug was initially created as a clone of Bug #1133890 +++

Description of problem:

Live merge is blocked with CanDoAction to the attempts to remove a single snapshot from disk via snapshot overview feature.
This operation should be allowed due to the fact,Live merge operates on disk's volume, http://www.ovirt.org/Features/Live_Merge#Summary , thus, supports the live deletion of a single snapshot.

Version-Release number of selected component (if applicable):
rc1.1

How reproducible:
100%

Steps to Reproduce:
1.have vm+disk + snapshot
2.run vm and attempt to remove the disk's snapshot from snapshot overview tab

Actual results:
operation is blocked with CDA

Expected results:
operation should be allowed and successful

Additional info:

--- Additional comment from Allon Mureinik on 2014-08-26 12:47:14 EDT ---

Ori, please add the log.

--- Additional comment from Greg Padgett on 2014-08-26 14:29:04 EDT ---

I've reproduced this, assuming it's this error from the Storage > Disk Snapshots:

2014-08-26 14:16:53,407 WARN  [org.ovirt.engine.core.bll.RemoveDiskSnapshotsCommand] (http--0.0.0.0-8080-1) [f58e694] CanDoAction of action RemoveDiskSnapshots failed. Reasons:VAR__ACTION__REMOVE,VAR__TYPE__DISK__SNAPSHOT,ACTION_TYPE_FAILED_VM_IS_NOT_DOWN

--- Additional comment from Greg Padgett on 2014-08-27 13:55:58 EDT ---

Turns out that not only is this blocked, but lacks implementation as well.  The command used to remove snapshots from here is different than from the VM Disk tab, and will need to be branched for Live Merge.  I'm working on it, but it's not the small change to CDA I was hoping for.

--- Additional comment from Ori Gofen on 2014-09-01 03:09:30 EDT ---

logs attached as asked.

2014-09-01 10:06:07,922 WARN  [org.ovirt.engine.core.bll.RemoveDiskSnapshotsCommand] (ajp--127.0.0.1-8702-10) [329fe6e1] CanDoAction of action RemoveDiskSnapshots failed. Reasons:VAR__ACTION__REMOVE,VAR__TYPE__DISK__SNAPSHOT,ACTION_TYPE_FAILED_VM_IS_NOT_DOWN
2014-09-01 10:06:07,930 INFO  [org.ovirt.engine.core.bll.RemoveDiskSnapshotsCommand] (ajp--127.0.0.1-8702-10) [329fe6e1] Lock freed to object EngineLock [exclusiveLocks= key: 05af808b-0ee0-49cb-94dc-1028dbb13082 value: DISK
, sharedLocks= ]
2014-09-01 10:06:23,982 INFO  [org.ovirt.engine.core.bll.RemoveDiskSnapshotsCommand] (ajp--127.0.0.1-8702-2) [42f295a8] Lock Acquired to object EngineLock [exclusiveLocks= key: 05af808b-0ee0-49cb-94dc-1028dbb13082 value: DISK
, sharedLocks= ]
2014-09-01 10:06:23,994 WARN  [org.ovirt.engine.core.bll.RemoveDiskSnapshotsCommand] (ajp--127.0.0.1-8702-2) [42f295a8] CanDoAction of action RemoveDiskSnapshots failed. Reasons:VAR__ACTION__REMOVE,VAR__TYPE__DISK__SNAPSHOT,ACTION_TYPE_FAILED_VM_IS_NOT_DOWN
2014-09-01 10:06:24,000 INFO  [org.ovirt.engine.core.bll.RemoveDiskSnapshotsCommand] (ajp--127.0.0.1-8702-2) [42f295a8] Lock freed to object EngineLock [exclusiveLocks= key: 05af808b-0ee0-49cb-94dc-1028dbb13082 value: DISK
, sharedLocks= ]
2014-09-01 10:06:24,657 INFO  [org.ovirt.engine.core.bll.OvfDataUpdater] (DefaultQuartzScheduler_Worker-11) Attempting to update VMs/Templates Ovf.
2014-09-01 10:06:31,135 INFO  [org.ovirt.engine.core.bll.RemoveDiskSnapshotsCommand] (ajp--127.0.0.1-8702-4) [5cfe6181] Lock Acquired to object EngineLock [exclusiveLocks= key: 05af808b-0ee0-49cb-94dc-1028dbb13082 value: DISK
, sharedLocks= ]
2014-09-01 10:06:31,146 WARN  [org.ovirt.engine.core.bll.RemoveDiskSnapshotsCommand] (ajp--127.0.0.1-8702-4) [5cfe6181] CanDoAction of action RemoveDiskSnapshots failed. Reasons:VAR__ACTION__REMOVE,VAR__TYPE__DISK__SNAPSHOT,ACTION_TYPE_FAILED_VM_IS_NOT_DOWN
2014-09-01 10:06:31,152 INFO  [org.ovirt.engine.core.bll.RemoveDiskSnapshotsCommand] (ajp--127.0.0.1-8702-4) [5cfe6181] Lock freed to object EngineLock [exclusiveLocks= key: 05af808b-0ee0-49cb-94dc-1028dbb13082 value: DISK
, sharedLocks= ]

Comment 2 Allon Mureinik 2014-12-24 12:28:44 UTC
Moved back to MODIFIED, should be ON_QA when there's a 3.6.0 build.

Comment 3 Kevin Alon Goldblatt 2015-04-28 15:05:00 UTC
Verified with version:
----------------------
v3.6
ovirt-engine-3.6.0-0.0.master.20150412172306.git55ba764.el6.noarch
vdsm-4.17.0-632.git19a83a2.el7.x86_64

Verified with scenario:
------------------------
Steps to Reproduce:
1.have vm+disk + snapshot
2.run vm and attempt to remove the disk's snapshot from snapshot overview tab - the operation is successful and the snapshot disk is removed.


Moving to verified!

Comment 4 Allon Mureinik 2016-03-10 10:37:35 UTC
RHEV 3.6.0 has been released, setting status to CLOSED CURRENTRELEASE

Comment 5 Allon Mureinik 2016-03-10 10:38:12 UTC
RHEV 3.6.0 has been released, setting status to CLOSED CURRENTRELEASE

Comment 6 Allon Mureinik 2016-03-10 10:44:00 UTC
RHEV 3.6.0 has been released, setting status to CLOSED CURRENTRELEASE

Comment 7 Allon Mureinik 2016-03-10 12:00:44 UTC
RHEV 3.6.0 has been released, setting status to CLOSED CURRENTRELEASE


Note You need to log in before you can comment on or make changes to this bug.