Bug 1135470 (kf5-kscreen, libkscreen-qt5)
| Summary: | Review Request: libkscreen-qt5 - KDE display configuration library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Vrátil <dvratil> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | Jan Grulich <jgrulich> |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | gwync, jeischma, jgrulich, kevin, package-review, rdieter, than |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | jgrulich:
fedora-review+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-05-25 08:26:05 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1135103 | ||
|
Description
Daniel Vrátil
2014-08-29 12:11:22 UTC
In Description macro %{Summary} will be unexpanded so use %{summary} instead. You are also missing to install license file. The rest looks good and both mentioned issues could be done during import.
Similar to my comments in the kf5-libmm-qt review, I think we could consider recycling the existing fedora pkg/module libkscreen , the only items that currently depend on it are kscreen (should have plasma5 version soonish, right?) okular (optional feature) If not, I'd prefer this be called kf5-libkscreen (to match the tarball) Unlike libmm-qt/libnm-qt, libkscreen is not going to become a KDE Framework, instead will remain as a support library for Plasma 5, so I agree that we can just reuse the existing libkscreen package. Closing this request. Reopening: libkscreen is required by okular-libs. Unless we make sure we have KF5-based Okular in rawhide (I don't know what the porting plans of Okular are), we might need to go for libkscreen-qt5 or something like that. Opinions? -qt5 is fine with me if you don't want to use kf5- prefix for reasons(tm). Spec URL: https://dvratil.fedorapeople.org/plasma5/review/libkscreen-qt5.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/libkscreen-qt5-5.1.95-1.beta.fc21.src.rpm Output from rpmlint: libkscreen-qt5.src: W: invalid-url URL: https://projects.kde.org/projects/extragear/libs/libkscreen HTTP Error 404: Not Found libkscreen-qt5.src:1: W: macro-in-comment %global libkscreen-qt5.src:2: W: macro-in-comment %global libkscreen-qt5.src:17: W: macro-in-comment %{git_version} 1 packages and 0 specfiles checked; 0 errors, 4 warnings. No blocking issue spotted, just fix the url during import. New Package SCM Request ======================= Package Name: libkscreen-qt5 Short Description: KDE display configuration library Upstream URL: https://projects.kde.org/projects/kde/workspace/libkscreen Owners: group::kde-sig Branches: InitialCC: Git done (by process-git-requests). New Package SCM Request ======================= Package Name: libkscreen-qt5 Short Description: KDE display configuration library Upstream URL: https://projects.kde.org/projects/kde/workspace/libkscreen Owners: group::kde-sig Branches: epel7 Branch requests are done in pkgdb these days, fyi thanks |