Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kf5-kscreen.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kf5-kscreen-5.0.92-1.fc20.src.rpm Description: A Tier 3 KDE Frameworks 5 Library with API to control screen settings. Fedora Account System Username: dvratil
In Description macro %{Summary} will be unexpanded so use %{summary} instead. You are also missing to install license file. The rest looks good and both mentioned issues could be done during import.
Similar to my comments in the kf5-libmm-qt review, I think we could consider recycling the existing fedora pkg/module libkscreen , the only items that currently depend on it are kscreen (should have plasma5 version soonish, right?) okular (optional feature)
If not, I'd prefer this be called kf5-libkscreen (to match the tarball)
Unlike libmm-qt/libnm-qt, libkscreen is not going to become a KDE Framework, instead will remain as a support library for Plasma 5, so I agree that we can just reuse the existing libkscreen package. Closing this request.
Reopening: libkscreen is required by okular-libs. Unless we make sure we have KF5-based Okular in rawhide (I don't know what the porting plans of Okular are), we might need to go for libkscreen-qt5 or something like that. Opinions?
-qt5 is fine with me if you don't want to use kf5- prefix for reasons(tm).
Spec URL: https://dvratil.fedorapeople.org/plasma5/review/libkscreen-qt5.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/libkscreen-qt5-5.1.95-1.beta.fc21.src.rpm
Output from rpmlint: libkscreen-qt5.src: W: invalid-url URL: https://projects.kde.org/projects/extragear/libs/libkscreen HTTP Error 404: Not Found libkscreen-qt5.src:1: W: macro-in-comment %global libkscreen-qt5.src:2: W: macro-in-comment %global libkscreen-qt5.src:17: W: macro-in-comment %{git_version} 1 packages and 0 specfiles checked; 0 errors, 4 warnings. No blocking issue spotted, just fix the url during import.
New Package SCM Request ======================= Package Name: libkscreen-qt5 Short Description: KDE display configuration library Upstream URL: https://projects.kde.org/projects/kde/workspace/libkscreen Owners: group::kde-sig Branches: InitialCC:
Git done (by process-git-requests).
New Package SCM Request ======================= Package Name: libkscreen-qt5 Short Description: KDE display configuration library Upstream URL: https://projects.kde.org/projects/kde/workspace/libkscreen Owners: group::kde-sig Branches: epel7
Branch requests are done in pkgdb these days, fyi
thanks