Bug 1135511 (kmenuedit)

Summary:	Review Request: kmenuedit - KDE menu editor
Product:	[Fedora] Fedora	Reporter:	Daniel Vrátil <dvratil>
Component:	Package Review	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	dvratil, jeischma, kevin, package-review, rdieter
Target Milestone:	---	Flags:	rdieter: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-01-29 14:58:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1135103

Description Daniel Vrátil 2014-08-29 13:44:43 UTC

Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kmenuedit.spec
SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kmenuedit-5.0.1-1.fc20.src.rpm
Description: KDE menu editor.
Fedora Account System Username: dvratil

Comment 1 Rex Dieter 2014-12-31 22:10:48 UTC

scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=8508331

naming: ok

sources: ok
7941bb5b43b6abc883d98c384f6f062a  kmenuedit-5.0.1.tar.xz

macros: ok (mostly)

1.  SHOULD use
make install/fast DESTDIR=%{buildroot} -C %{_target_platform}
in preference over
%make_install -C %{_target_platform}


scriptlets: ok

2.  MUST add
BuildRequires: desktop-file-utils
and
%check
desktop-file-validate %{buildroot}%{_datadir}/applications/kmenuedit.desktop

Comment 2 Rex Dieter 2014-12-31 22:13:23 UTC

scratch build failed, 

/usr/include/qt5/QtCore/qshareddata.h: In instantiation of 'QExplicitlySharedDataPointer<T>::QExplicitlySharedDataPointer(const QExplicitlySharedDataPointer<X>&) [with X = KSycocaEntry; T = KServiceGroup]':
../treeview.cpp:376:67:   required from here
/usr/include/qt5/QtCore/qshareddata.h:166:21: error: invalid conversion from 'KSycocaEntry*' to 'KServiceGroup*' [-fpermissive]
         : d(o.data())
                     ^
/usr/include/qt5/QtCore/qshareddata.h: In instantiation of 'QExplicitlySharedDataPointer<T>::QExplicitlySharedDataPointer(const QExplicitlySharedDataPointer<X>&) [with X = KSycocaEntry; T = KService]':
../treeview.cpp:381:62:   required from here
/usr/include/qt5/QtCore/qshareddata.h:166:21: error: invalid conversion from 'KSycocaEntry*' to 'KService*' [-fpermissive]

I suspect we probably just need an update (newer version) to work with latest kf5.

Comment 3 Daniel Vrátil 2015-01-06 16:05:21 UTC

Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kmenuedit.spec
SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kmenuedit-5.1.2-1.fc21.src.rpm

Updated to latest upstream version

Comment 4 Daniel Vrátil 2015-01-16 10:48:04 UTC

Ping?

Comment 5 Rex Dieter 2015-01-16 13:51:37 UTC

boo, hadn't noticed this before, but

%{_datadir}/icons/hicolor/*/apps/kmenuedit.png

3. MUST add icon scriptlets

Comment 6 Daniel Vrátil 2015-01-20 11:02:44 UTC

Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kmenuedit.spec
SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kmenuedit-5.1.2-2.fc21.src.rpm

- added icon scriptlet

Comment 7 Rex Dieter 2015-01-20 13:07:54 UTC

Thanks, looks good.

APPROVED

Comment 8 Daniel Vrátil 2015-01-21 13:03:29 UTC

New Package SCM Request
=======================
Package Name: kmenuedit
Short Description: KDE menu editor
Upstream URL: https://projects.kde.org/projects/kde/workspace/kmenuedit
Owners: group::kde-sig
Branches:
InitialCC:

Comment 9 Gwyn Ciesla 2015-01-21 15:22:05 UTC

Git done (by process-git-requests).