Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kmenuedit.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kmenuedit-5.0.1-1.fc20.src.rpm Description: KDE menu editor. Fedora Account System Username: dvratil
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8508331 naming: ok sources: ok 7941bb5b43b6abc883d98c384f6f062a kmenuedit-5.0.1.tar.xz macros: ok (mostly) 1. SHOULD use make install/fast DESTDIR=%{buildroot} -C %{_target_platform} in preference over %make_install -C %{_target_platform} scriptlets: ok 2. MUST add BuildRequires: desktop-file-utils and %check desktop-file-validate %{buildroot}%{_datadir}/applications/kmenuedit.desktop
scratch build failed, /usr/include/qt5/QtCore/qshareddata.h: In instantiation of 'QExplicitlySharedDataPointer<T>::QExplicitlySharedDataPointer(const QExplicitlySharedDataPointer<X>&) [with X = KSycocaEntry; T = KServiceGroup]': ../treeview.cpp:376:67: required from here /usr/include/qt5/QtCore/qshareddata.h:166:21: error: invalid conversion from 'KSycocaEntry*' to 'KServiceGroup*' [-fpermissive] : d(o.data()) ^ /usr/include/qt5/QtCore/qshareddata.h: In instantiation of 'QExplicitlySharedDataPointer<T>::QExplicitlySharedDataPointer(const QExplicitlySharedDataPointer<X>&) [with X = KSycocaEntry; T = KService]': ../treeview.cpp:381:62: required from here /usr/include/qt5/QtCore/qshareddata.h:166:21: error: invalid conversion from 'KSycocaEntry*' to 'KService*' [-fpermissive] I suspect we probably just need an update (newer version) to work with latest kf5.
Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kmenuedit.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kmenuedit-5.1.2-1.fc21.src.rpm Updated to latest upstream version
Ping?
boo, hadn't noticed this before, but %{_datadir}/icons/hicolor/*/apps/kmenuedit.png 3. MUST add icon scriptlets
Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kmenuedit.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kmenuedit-5.1.2-2.fc21.src.rpm - added icon scriptlet
Thanks, looks good. APPROVED
New Package SCM Request ======================= Package Name: kmenuedit Short Description: KDE menu editor Upstream URL: https://projects.kde.org/projects/kde/workspace/kmenuedit Owners: group::kde-sig Branches: InitialCC:
Git done (by process-git-requests).