Bug 1135519 (kio-extras)
| Summary: | Review Request: kio-extras - Additional components to increase the functionality of KIO Framework | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Vrátil <dvratil> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | Jan Grulich <jgrulich> |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | i, jeischma, jgrulich, kevin, package-review, rdieter |
| Target Milestone: | --- | Flags: | jgrulich:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-01-20 13:35:12 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1135103 | ||
|
Description
Daniel Vrátil
2014-08-29 13:59:10 UTC
What about taking this occasion to rename doc package from -docs to -doc? As from review template in fedora-review, doc packages should have a common name -doc... 1) kde-runtime-docs package doesn't exist, also as Christopher mentioned, you should use -docs instead of -doc. 2) There are some files conflicting in this version with kf5-kio-core, but this should be fixed when you update to a newer version. 3) Shouldn't you call ldconfig in %post and in %postun? 4) Missing call of update-desktop-database - see http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database 5) Missing license file Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kio-extras.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kio-extras-5.1.2-2.fc20.src.rpm 1) kde-runtime-docs exists now (did not during the time I submitted the review) 2) fixed upstream 3) fixed 4) AFAIK we don't call update-desktop-database on KDE kservice desktop files 5) there's no top-level license file, as the submodules have different license files in their subfolders. Shall we extract at least one? Correct URL: Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kio-extras.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kio-extras-5.1.2-2.fc21.src.rpm Ok, looks good now, not sure about the license file, but if there is no top-level license file I would leave it as it is. Spotted 2 more issues: - url should be https://projects.kde.org/projects/kde/workspace/kio-extras - use make install make install/fast DESTDIR=%{buildroot} -C %{_target_platform} instead of %make_install ... Fixed locally. New Package SCM Request ======================= Package Name: kio-extras Short Description: Additional components to increase the functionality of KIO Framework Upstream URL: https://projects.kde.org/projects/kde/workspace/kio-extras Owners: group::kde-sig Branches: InitialCC: Git done (by process-git-requests). |