Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kio-extras.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kio-extras-5.0.1-1.fc20.src.rpm Description: Additional components to increase the functionality of KIO Framework Fedora Account System Username: dvratil
What about taking this occasion to rename doc package from -docs to -doc? As from review template in fedora-review, doc packages should have a common name -doc...
1) kde-runtime-docs package doesn't exist, also as Christopher mentioned, you should use -docs instead of -doc. 2) There are some files conflicting in this version with kf5-kio-core, but this should be fixed when you update to a newer version. 3) Shouldn't you call ldconfig in %post and in %postun? 4) Missing call of update-desktop-database - see http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database 5) Missing license file
Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kio-extras.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kio-extras-5.1.2-2.fc20.src.rpm 1) kde-runtime-docs exists now (did not during the time I submitted the review) 2) fixed upstream 3) fixed 4) AFAIK we don't call update-desktop-database on KDE kservice desktop files 5) there's no top-level license file, as the submodules have different license files in their subfolders. Shall we extract at least one?
Correct URL: Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kio-extras.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kio-extras-5.1.2-2.fc21.src.rpm
Ok, looks good now, not sure about the license file, but if there is no top-level license file I would leave it as it is.
Spotted 2 more issues: - url should be https://projects.kde.org/projects/kde/workspace/kio-extras - use make install make install/fast DESTDIR=%{buildroot} -C %{_target_platform} instead of %make_install ...
Fixed locally.
New Package SCM Request ======================= Package Name: kio-extras Short Description: Additional components to increase the functionality of KIO Framework Upstream URL: https://projects.kde.org/projects/kde/workspace/kio-extras Owners: group::kde-sig Branches: InitialCC:
Git done (by process-git-requests).