Bug 1136734

Summary: Faulty storage allocation checks when importing a VM template from ovf
Product: [Retired] oVirt Reporter: Vered Volansky <vered>
Component: ovirt-engine-coreAssignee: Vered Volansky <vered>
Status: CLOSED CURRENTRELEASE QA Contact: Aharon Canan <acanan>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.4CC: acanan, amureini, bugs, dfediuck, ecohen, eedri, gklein, iheim, jkt, lpeer, nlevinki, obasan, rbalakri, Rhev-m-bugs, scohen, vered, yeylon
Target Milestone: ---   
Target Release: 3.5.0   
Hardware: Unspecified   
OS: All   
Whiteboard: storage
Fixed In Version: ovirt-engine-3.5.0_beta2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1136721 Environment:
Last Closed: 2014-10-17 12:27:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1053746, 1136721    
Bug Blocks: 960934    

Description Vered Volansky 2014-09-03 07:46:25 UTC
The storage requirements for each disk in the imported template:


For new empty disks (unchanged from the original)
      | File Domain                             | Block Domain
 -----|-----------------------------------------|-------------
 qcow | 1M (header size)                        | 1G
 -----|-----------------------------------------|-------------
 raw  | preallocated: disk capacity (getSize()) | disk capacity
      | thin (sparse): 1M                       | (there is no raw sparse on 
                                                   block domains)

Comment 1 Vered Volansky 2014-09-03 08:06:16 UTC
Disregard bug description (comment #0).
The scenario is conducted through ImportVmTemplateFromConfigurationCommand.
This is triggered by import a storage domain, where the disks already exist in the system, so just make sure there storage allocation tests always pass on this scenario.

Comment 2 Vered Volansky 2014-09-18 10:47:53 UTC
In this command CDA verifications should never get to storage allocations. Moving straight to ON_QA.
Fixed In Version: ovirt-3.5.0-beta2

What should be verified is that this command never fails on insufficient storage space when importing a vm template with disks.

On registration the disks should already be on the storage domain, and they're only attached to the template. If the do not already exist on the storage domain, the vm template will be imported without the missing disks.

1. Create a VMTemplate with 7 disks, each disk 1 GB
2. Export the template
3. Detach the Storage Domain
4. Attach the Storage Domain to another DC
5. Activate it
6. Create disks on the Storage Domain until its free space is < 7 GB
7. Try to import the VMTemplate that you exported - Should fail on CDA
8. Try to register the VMTemplate - should succeed

Comment 3 Aharon Canan 2014-09-22 06:54:27 UTC
verified using vt3.1

following steps in comment #2

Comment 4 Sandro Bonazzola 2014-10-17 12:27:04 UTC
oVirt 3.5 has been released and should include the fix for this issue.