Bug 1139043
| Summary: | Review Request: perl-Array-Unique - Tie-able array that allows only unique values | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Denis Fateyev <denis> |
| Component: | Package Review | Assignee: | David Dick <ddick> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ddick, package-review, perl-devel |
| Target Milestone: | --- | Flags: | ddick:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Array-Unique-0.08-2.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-10-08 19:12:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Denis Fateyev
2014-09-07 19:16:48 UTC
Builds okay in rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=7711524 license is good. rpmlint only has incorrect spelling warnings and may be ignored. BR: perl(Test::Pod) BR: perl(Test::Pod::Coverage) BR: perl(Test::Perl::Critic) can be removed as they are not included in the test suite that is run. They are only in the xt directory. The "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;" line can be removed. It is not necessary for >= EPEL5 How are you building your EPEL5 packages? (In reply to David Dick from comment #1) > BR: perl(Test::Pod) > BR: perl(Test::Pod::Coverage) > BR: perl(Test::Perl::Critic) > > can be removed as they are not included in the test suite that is run. They > are only in the xt directory. OK. I thought whether they were needed if they were mentioned in "xt". > The "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;" line > can be removed. It is not necessary for >= EPEL5 OK. I was concerned if it was working with EPEL5 too. Updated spec: http://www.fateyev.com/RPMS/Fedora20/testing/perl-Array-Unique.spec SRPM: http://www.fateyev.com/RPMS/Fedora20/testing/SRPMS/perl-Array-Unique-0.08-2.fc20.denf.src.rpm Koji scratch builds: https://koji.fedoraproject.org/koji/taskinfo?taskID=7714825 (Rawhide) https://koji.fedoraproject.org/koji/taskinfo?taskID=7714827 (EPEL7) > How are you building your EPEL5 packages? Well, it's not possible to push F20 SRPMs directly due to a bug with MD5 checking in RHEL5. Since I've got here some OpenVZ containers with RHEL5 installed, I wrote a tiny script which copies and installs SRPMs into EL5 container (`rpm -ivh --nomd5 package.src.rpm`), runs `rpmbuild` or `mock` inside, and gets me results back. Such "native" SRPM can be passed in EPEL5 scratch build. (Of course, OpenVZ is not the only option here.) (In reply to Denis Fateyev from comment #2) > (In reply to David Dick from comment #1) > > > BR: perl(Test::Pod) > > BR: perl(Test::Pod::Coverage) > > BR: perl(Test::Perl::Critic) > > > > can be removed as they are not included in the test suite that is run. They > > are only in the xt directory. > > OK. I thought whether they were needed if they were mentioned in "xt". Every module that is required during build/test/install. The "make test" does not use the "xt" directory, so it may be ignored. > > The "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;" line > > can be removed. It is not necessary for >= EPEL5 > > OK. I was concerned if it was working with EPEL5 too. I'm pretty sure that it is not required. If you get a build failure for EPEL5, just re-add it. Package APPROVED! New Package SCM Request ======================= Package Name: perl-Array-Unique Short Description: Tie-able array that allows only unique values Owners: dfateyev Branches: f19 f20 f21 el5 el6 epel7 InitialCC: perl-sig Git done (by process-git-requests). perl-Array-Unique-0.08-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-Array-Unique-0.08-2.fc21 perl-Array-Unique-0.08-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Array-Unique-0.08-2.fc20 perl-Array-Unique-0.08-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Array-Unique-0.08-2.fc19 perl-Array-Unique-0.08-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-Array-Unique-0.08-2.el7 perl-Array-Unique-0.08-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Array-Unique-0.08-2.el6 perl-Array-Unique-0.08-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Array-Unique-0.08-2.el5 perl-Array-Unique-0.08-2.el6 has been pushed to the Fedora EPEL 6 testing repository. perl-Array-Unique-0.08-2.fc21 has been pushed to the Fedora 21 stable repository. perl-Array-Unique-0.08-2.fc19 has been pushed to the Fedora 19 stable repository. perl-Array-Unique-0.08-2.fc20 has been pushed to the Fedora 20 stable repository. perl-Array-Unique-0.08-2.el6 has been pushed to the Fedora EPEL 6 stable repository. perl-Array-Unique-0.08-2.el7 has been pushed to the Fedora EPEL 7 stable repository. perl-Array-Unique-0.08-2.el5 has been pushed to the Fedora EPEL 5 stable repository. |