Bug 1139043 - Review Request: perl-Array-Unique - Tie-able array that allows only unique values
Summary: Review Request: perl-Array-Unique - Tie-able array that allows only unique va...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Dick
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-07 19:16 UTC by Denis Fateyev
Modified: 2014-10-17 17:41 UTC (History)
3 users (show)

Fixed In Version: perl-Array-Unique-0.08-2.el5
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-10-08 19:12:31 UTC
Type: ---
Embargoed:
ddick: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Denis Fateyev 2014-09-07 19:16:48 UTC
Spec URL: http://www.fateyev.com/RPMS/Fedora20/testing/perl-Array-Unique.spec
SRPM URL: http://www.fateyev.com/RPMS/Fedora20/testing/SRPMS/perl-Array-Unique-0.08-1.fc20.denf.src.rpm
Description: This package lets you create an array which will allow only one
occurrence of any value. In other words, no matter how many times you put in 42 it will keep only the first occurrence and the rest will be dropped. You use the module via tie and once you tied your array to this module it will behave correctly.

Uniqueness is checked with the 'eq' operator so among other things it is case sensitive. As a side effect the module does not allow undef as a value in the array.
Fedora Account System Username: dfateyev

Koji scratch builds:
https://koji.fedoraproject.org/koji/taskinfo?taskID=7540753 (Rawhide)
https://koji.fedoraproject.org/koji/taskinfo?taskID=7540751 (EPEL 5)
https://koji.fedoraproject.org/koji/taskinfo?taskID=7540746 (EPEL 6)
https://koji.fedoraproject.org/koji/taskinfo?taskID=7540744 (EPEL 7)

Comment 1 David Dick 2014-09-28 09:46:19 UTC
Builds okay in rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=7711524

license is good.

rpmlint only has incorrect spelling warnings and may be ignored.

BR:  perl(Test::Pod)
BR:  perl(Test::Pod::Coverage)
BR:  perl(Test::Perl::Critic)

can be removed as they are not included in the test suite that is run.  They are only in the xt directory.

The "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;" line can be removed.  It is not necessary for >= EPEL5

How are you building your EPEL5 packages?

Comment 2 Denis Fateyev 2014-09-28 20:57:22 UTC
(In reply to David Dick from comment #1)

> BR:  perl(Test::Pod)
> BR:  perl(Test::Pod::Coverage)
> BR:  perl(Test::Perl::Critic)
> 
> can be removed as they are not included in the test suite that is run.  They
> are only in the xt directory.

OK. I thought whether they were needed if they were mentioned in "xt".

> The "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;" line
> can be removed.  It is not necessary for >= EPEL5

OK. I was concerned if it was working with EPEL5 too.

Updated spec: http://www.fateyev.com/RPMS/Fedora20/testing/perl-Array-Unique.spec
SRPM: http://www.fateyev.com/RPMS/Fedora20/testing/SRPMS/perl-Array-Unique-0.08-2.fc20.denf.src.rpm
Koji scratch builds:
https://koji.fedoraproject.org/koji/taskinfo?taskID=7714825 (Rawhide)
https://koji.fedoraproject.org/koji/taskinfo?taskID=7714827 (EPEL7)

> How are you building your EPEL5 packages?
Well, it's not possible to push F20 SRPMs directly due to a bug with MD5 checking in RHEL5. Since I've got here some OpenVZ containers with RHEL5 installed, I wrote a tiny script which copies and installs SRPMs into EL5 container (`rpm -ivh --nomd5 package.src.rpm`), runs `rpmbuild` or `mock` inside, and gets me results back. Such "native" SRPM can be passed in EPEL5 scratch build. (Of course, OpenVZ is not the only option here.)

Comment 3 David Dick 2014-09-29 08:35:41 UTC
(In reply to Denis Fateyev from comment #2)
> (In reply to David Dick from comment #1)
> 
> > BR:  perl(Test::Pod)
> > BR:  perl(Test::Pod::Coverage)
> > BR:  perl(Test::Perl::Critic)
> > 
> > can be removed as they are not included in the test suite that is run.  They
> > are only in the xt directory.
> 
> OK. I thought whether they were needed if they were mentioned in "xt".

Every module that is required during build/test/install.  The "make test" does not use the "xt" directory, so it may be ignored.
 
> > The "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;" line
> > can be removed.  It is not necessary for >= EPEL5
> 
> OK. I was concerned if it was working with EPEL5 too.

I'm pretty sure that it is not required.  If you get a build failure for EPEL5, just re-add it. 

Package APPROVED!

Comment 4 Denis Fateyev 2014-09-30 22:14:21 UTC
New Package SCM Request
=======================
Package Name: perl-Array-Unique
Short Description: Tie-able array that allows only unique values
Owners: dfateyev
Branches: f19 f20 f21 el5 el6 epel7
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2014-10-01 09:50:20 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2014-10-02 15:05:23 UTC
perl-Array-Unique-0.08-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-Array-Unique-0.08-2.fc21

Comment 7 Fedora Update System 2014-10-02 15:06:45 UTC
perl-Array-Unique-0.08-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Array-Unique-0.08-2.fc20

Comment 8 Fedora Update System 2014-10-02 15:07:38 UTC
perl-Array-Unique-0.08-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-Array-Unique-0.08-2.fc19

Comment 9 Fedora Update System 2014-10-02 15:08:32 UTC
perl-Array-Unique-0.08-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/perl-Array-Unique-0.08-2.el7

Comment 10 Fedora Update System 2014-10-02 15:09:41 UTC
perl-Array-Unique-0.08-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-Array-Unique-0.08-2.el6

Comment 11 Fedora Update System 2014-10-02 15:10:54 UTC
perl-Array-Unique-0.08-2.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/perl-Array-Unique-0.08-2.el5

Comment 12 Fedora Update System 2014-10-02 17:05:11 UTC
perl-Array-Unique-0.08-2.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 13 Fedora Update System 2014-10-08 19:12:31 UTC
perl-Array-Unique-0.08-2.fc21 has been pushed to the Fedora 21 stable repository.

Comment 14 Fedora Update System 2014-10-11 06:57:27 UTC
perl-Array-Unique-0.08-2.fc19 has been pushed to the Fedora 19 stable repository.

Comment 15 Fedora Update System 2014-10-11 07:03:10 UTC
perl-Array-Unique-0.08-2.fc20 has been pushed to the Fedora 20 stable repository.

Comment 16 Fedora Update System 2014-10-17 17:32:21 UTC
perl-Array-Unique-0.08-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 17 Fedora Update System 2014-10-17 17:41:19 UTC
perl-Array-Unique-0.08-2.el7 has been pushed to the Fedora EPEL 7 stable repository.

Comment 18 Fedora Update System 2014-10-17 17:41:59 UTC
perl-Array-Unique-0.08-2.el5 has been pushed to the Fedora EPEL 5 stable repository.


Note You need to log in before you can comment on or make changes to this bug.