Bug 1139103

Summary: DHT + Snapshot :- If snapshot is taken when Directory is created only on hashed sub-vol; On restoring that snapshot Directory is not listed on mount point and lookup on parent is not healing
Product: [Community] GlusterFS Reporter: Nithya Balachandran <nbalacha>
Component: distributeAssignee: Nithya Balachandran <nbalacha>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.5.2CC: gluster-bugs, nsathyan, racpatel, rgowdapp, spalai
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.5.3 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1092433 Environment:
Last Closed: 2014-11-21 16:02:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1090986, 1092433, 1139986    
Bug Blocks: 1125231    

Comment 1 Anand Avati 2014-09-15 07:27:25 UTC
REVIEW: http://review.gluster.org/8713 (DHT/readdirp: Directory not shown/healed on mount point if exists               on single brick(non first up subvolume).) posted (#1) for review on release-3.5 by N Balachandran (nbalacha)

Comment 2 Anand Avati 2014-09-17 15:33:42 UTC
COMMIT: http://review.gluster.org/8713 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit c53aab61b8ff5957a306f499565be0ab3ff0fb78
Author: Susant Palai <spalai>
Date:   Wed Sep 10 21:24:41 2014 +0530

    DHT/readdirp: Directory not shown/healed on mount point if exists
                  on single brick(non first up subvolume).
    
    Problem: If snapshot is taken, when mkdir has succeeded only on
    hashed_subvolume, then after restoring snapshot the directory
    is not shown on mount point.
    
    Why:    dht_readdirp takes only those directory entries in to
    account, which are present on first_up_subvolume. Hence, if the
    "hashed subvolume" is not same as first_up_subvolume, it wont be listed
    on mount point and also not healed.
    
    Solution:
    Case 1: (Rebalance not running)If hashed subvolume is NULL or down then
    filter in first_up_subvolume. Other wise the corresponding hashed subvolume
    will take care of the directory entry.
    
    Case 2: If readdirp_optimize option is turned on then read from first_up_subvol
    
    Change-Id: Idaad28f1c9f688dbfb1a8a3ab8b244510c02365e
    BUG: 1139103
    Signed-off-by: Susant Palai <spalai>
    Reviewed-on: http://review.gluster.org/7599
    Reviewed-by: Raghavendra G <rgowdapp>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>
    (cherry picked from commit b8f3aab95f01ac7d590a5ba490e890d9cf8c2e50)
    Signed-off-by: Nithya Balachandran <nbalacha>
    Reviewed-on: http://review.gluster.org/8713
    Reviewed-by: Jeff Darcy <jdarcy>
    Reviewed-by: Niels de Vos <ndevos>

Comment 3 Niels de Vos 2014-10-05 12:59:52 UTC
The first (and last?) Beta for GlusterFS 3.5.3 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.3beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-October/018990.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 4 Niels de Vos 2014-11-05 09:24:33 UTC
The second Beta for GlusterFS 3.5.3 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.3beta2 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions have been made available on [2] to make testing easier.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019359.html
[2] http://download.gluster.org/pub/gluster/glusterfs/qa-releases/3.5.3beta2/

Comment 5 Niels de Vos 2014-11-21 16:02:17 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.3, please reopen this bug report.

glusterfs-3.5.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/announce/2014-November/000042.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/