Bug 1139244

Summary:	vdsm invoked oom-killer during rebalance and Killed process 4305, UID 0, (glusterfs nfs process)
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	nfs	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	3.6.0	CC:	bugs, gluster-bugs
Target Milestone:	---	Keywords:	EasyFix, Patch
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.6.0beta1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-11-11 08:38:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1139195
Bug Blocks:	1117822

Description Niels de Vos 2014-09-08 13:08:39 UTC

3.6 needs the following backport:


COMMIT: http://review.gluster.org/8651 committed in master by Niels de Vos (ndevos) 
------
commit 5c869aea79c0f304150eac014c7177e74ce0852e
Author: Santosh Kumar Pradhan <spradhan>
Date:   Mon Sep 8 16:44:23 2014 +0530

    gNFS: Fix memory leak in setacl code path
    
    If ACL is set on a file in Gluster NFS mount (setfacl command),
    and it succeed, then the NFS call state data is leaked. Though
    all the failure code path frees up the memory.
    
    Impact: There is a OOM kill i.e. vdsm invoked oom-killer during
    rebalance and Killed process 4305, UID 0, (glusterfs nfs process)
    
    FIX:
    Make sure to deallocate the memory for call state in acl3_setacl_cbk()
    using nfs3_call_state_wipe();
    
    Signed-off-by: Santosh Kumar Pradhan <spradhan>
    
    Change-Id: I9caa3f851e49daaba15be3eec626f1f2dd8e45b3
    BUG: 1139195
    Signed-off-by: Santosh Kumar Pradhan <spradhan>
    Reviewed-on: http://review.gluster.org/8651
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 1 Anand Avati 2014-09-08 14:44:14 UTC

REVIEW: http://review.gluster.org/8654 (gNFS: Fix memory leak in setacl code path) posted (#1) for review on release-3.6 by Niels de Vos (ndevos)

Comment 2 Anand Avati 2014-09-16 11:27:27 UTC

COMMIT: http://review.gluster.org/8654 committed in release-3.6 by Vijay Bellur (vbellur) 
------
commit ac6b4eafee170ed00b44c9df2b96da47733bf8bf
Author: Niels de Vos <ndevos>
Date:   Mon Sep 8 16:06:34 2014 +0200

    gNFS: Fix memory leak in setacl code path
    
    If ACL is set on a file in Gluster NFS mount (setfacl command),
    and it succeed, then the NFS call state data is leaked. Though
    all the failure code path frees up the memory.
    
    Impact: There is a OOM kill i.e. vdsm invoked oom-killer during
    rebalance and Killed process 4305, UID 0, (glusterfs nfs process)
    
    FIX:
    Make sure to deallocate the memory for call state in acl3_setacl_cbk()
    using nfs3_call_state_wipe();
    
    Cherry picked from commit 5c869aea79c0f304150eac014c7177e74ce0852e:
    > Change-Id: I9caa3f851e49daaba15be3eec626f1f2dd8e45b3
    > BUG: 1139195
    > Signed-off-by: Santosh Kumar Pradhan <spradhan>
    > Reviewed-on: http://review.gluster.org/8651
    > Tested-by: Gluster Build System <jenkins.com>
    > Reviewed-by: Niels de Vos <ndevos>
    
    Change-Id: I9caa3f851e49daaba15be3eec626f1f2dd8e45b3
    BUG: 1139244
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/8654
    Reviewed-by: Santosh Pradhan <spradhan>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Niels de Vos 2014-09-22 12:45:53 UTC

A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 4 Niels de Vos 2014-11-11 08:38:24 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users