Bug 1139245

Summary:	vdsm invoked oom-killer during rebalance and Killed process 4305, UID 0, (glusterfs nfs process)
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	nfs	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	3.5.2	CC:	bugs, gluster-bugs
Target Milestone:	---	Keywords:	Patch
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.5.3	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-11-21 16:02:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1139195
Bug Blocks:	1125231

Description Niels de Vos 2014-09-08 13:09:42 UTC

3.5 needs the following backport:


COMMIT: http://review.gluster.org/8651 committed in master by Niels de Vos (ndevos) 
------
commit 5c869aea79c0f304150eac014c7177e74ce0852e
Author: Santosh Kumar Pradhan <spradhan>
Date:   Mon Sep 8 16:44:23 2014 +0530

    gNFS: Fix memory leak in setacl code path
    
    If ACL is set on a file in Gluster NFS mount (setfacl command),
    and it succeed, then the NFS call state data is leaked. Though
    all the failure code path frees up the memory.
    
    Impact: There is a OOM kill i.e. vdsm invoked oom-killer during
    rebalance and Killed process 4305, UID 0, (glusterfs nfs process)
    
    FIX:
    Make sure to deallocate the memory for call state in acl3_setacl_cbk()
    using nfs3_call_state_wipe();
    
    Signed-off-by: Santosh Kumar Pradhan <spradhan>
    
    Change-Id: I9caa3f851e49daaba15be3eec626f1f2dd8e45b3
    BUG: 1139195
    Signed-off-by: Santosh Kumar Pradhan <spradhan>
    Reviewed-on: http://review.gluster.org/8651
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 1 Anand Avati 2014-09-09 07:17:43 UTC

REVIEW: http://review.gluster.org/8661 (gNFS: Fix memory leak in setacl code path) posted (#2) for review on release-3.5 by Niels de Vos (ndevos)

Comment 2 Anand Avati 2014-09-09 09:44:01 UTC

COMMIT: http://review.gluster.org/8661 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit 53204bd61d3f8c15e92a90a2497e4d4218f2b729
Author: Santosh Kumar Pradhan <spradhan>
Date:   Tue Sep 9 12:06:29 2014 +0530

    gNFS: Fix memory leak in setacl code path
    
    If ACL is set on a file in Gluster NFS mount (setfacl command),
    and it succeed, then the NFS call state data is leaked. Though
    all the failure code path frees up the memory.
    
    Impact: There is a OOM kill i.e. vdsm invoked oom-killer during
    rebalance and Killed process 4305, UID 0, (glusterfs nfs process)
    
    FIX:
    Make sure to deallocate the memory for call state in acl3_setacl_cbk()
    using nfs3_call_state_wipe().
    
    Cherry picked from commit 5c869aea79c0f304150eac014c7177e74ce0852e:
    > Change-Id: I9caa3f851e49daaba15be3eec626f1f2dd8e45b3
    > BUG: 1139195
    > Signed-off-by: Santosh Kumar Pradhan <spradhan>
    > Reviewed-on: http://review.gluster.org/8651
    > Tested-by: Gluster Build System <jenkins.com>
    > Reviewed-by: Niels de Vos <ndevos>
    
    Change-Id: Ia4fd03ce53a729c1a2bca86e507c39822a35efe1
    BUG: 1139245
    Signed-off-by: Santosh Kumar Pradhan <spradhan>
    Reviewed-on: http://review.gluster.org/8661
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Gluster Build System <jenkins.com>

Comment 4 Niels de Vos 2014-10-05 12:59:57 UTC

The first (and last?) Beta for GlusterFS 3.5.3 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.3beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-October/018990.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 5 Niels de Vos 2014-11-05 09:24:37 UTC

The second Beta for GlusterFS 3.5.3 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.3beta2 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions have been made available on [2] to make testing easier.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019359.html
[2] http://download.gluster.org/pub/gluster/glusterfs/qa-releases/3.5.3beta2/

Comment 6 Niels de Vos 2014-11-21 16:02:23 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.3, please reopen this bug report.

glusterfs-3.5.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/announce/2014-November/000042.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/