Bug 1140222
| Summary: | Review Request: perl-Scalar-Util-LooksLikeNumber - Access to looks_like_number() perl API function | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Šabata <psabata> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Scalar-Util-LooksLikeNumber-1.39.1-1.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-09-25 14:21:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1140223 | ||
|
Description
Petr Šabata
2014-09-10 14:04:00 UTC
URL and Source0 are usable Ok.
Source archive is original (SHA-256: 0f6ff3bbbc8f1e2f10c70d0b99cf04c90f8869973722035f3c8cd0b8adc4b48a). Ok.
Summary verified from lib/Scalar/Util/LooksLikeNumber.pm. Ok.
Description verified from lib/Scalar/Util/LooksLikeNumber.pm. Ok.
Copyright verified from ppport.h, LooksLikeNumber.xs, lib/Scalar/Util/LooksLikeNumber.pm. Ok.
XS code presents, architecture specific BuildArch is Ok.
All build-requires are specified. Ok.
All tests pass. Ok.
$ rpmlint perl-Scalar-Util-LooksLikeNumber.spec ../SRPMS/perl-Scalar-Util-LooksLikeNumber-1.39.1-1.fc22.src.rpm ../RPMS/x86_64/perl-Scalar-Util-LooksLikeNumber-*
perl-Scalar-Util-LooksLikeNumber.src: W: spelling-error %description -l en_US booleanized -> Boolean
perl-Scalar-Util-LooksLikeNumber.x86_64: W: spelling-error %description -l en_US booleanized -> Boolean
perl-Scalar-Util-LooksLikeNumber-debuginfo.x86_64: E: description-line-too-long C This package provides debug information for package perl-Scalar-Util-LooksLikeNumber.
3 packages and 1 specfiles checked; 1 errors, 2 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/x86_64/perl-Scalar-Util-LooksLikeNumber-1.39.1-1.fc22.x86_64.rpm
drwxr-xr-x 2 root root 0 Sep 10 17:14 /usr/lib64/perl5/vendor_perl/Scalar
drwxr-xr-x 2 root root 0 Sep 10 17:14 /usr/lib64/perl5/vendor_perl/Scalar/Util
-rw-r--r-- 1 root root 1051 Jun 30 16:45 /usr/lib64/perl5/vendor_perl/Scalar/Util/LooksLikeNumber.pm
drwxr-xr-x 2 root root 0 Sep 10 17:14 /usr/lib64/perl5/vendor_perl/auto/Scalar
drwxr-xr-x 2 root root 0 Sep 10 17:14 /usr/lib64/perl5/vendor_perl/auto/Scalar/Util
drwxr-xr-x 2 root root 0 Sep 10 17:14 /usr/lib64/perl5/vendor_perl/auto/Scalar/Util/LooksLikeNumber
-rwxr-xr-x 1 root root 11144 Sep 10 17:14 /usr/lib64/perl5/vendor_perl/auto/Scalar/Util/LooksLikeNumber/LooksLikeNumber.so
drwxr-xr-x 2 root root 0 Sep 10 17:14 /usr/share/doc/perl-Scalar-Util-LooksLikeNumber
-rw-r--r-- 1 root root 89 Jun 30 16:40 /usr/share/doc/perl-Scalar-Util-LooksLikeNumber/Changes
-rw-r--r-- 1 root root 235 Jun 30 16:29 /usr/share/doc/perl-Scalar-Util-LooksLikeNumber/README
-rw-r--r-- 1 root root 2203 Sep 10 17:14 /usr/share/man/man3/Scalar::Util::LooksLikeNumber.3pm.gz
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/x86_64/perl-Scalar-Util-LooksLikeNumber-1.39.1-1.fc22.x86_64.rpm | sort -f | uniq -c
1 libc.so.6()(64bit)
1 libc.so.6(GLIBC_2.2.5)(64bit)
1 libperl.so.5.20()(64bit)
1 perl(:MODULE_COMPAT_5.20.0)
1 perl(Exporter)
1 perl(strict)
1 perl(XSLoader)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
1 rtld(GNU_HASH)
Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/x86_64/perl-Scalar-Util-LooksLikeNumber-1.39.1-1.fc22.x86_64.rpm | sort -f | uniq -c
1 perl(Scalar::Util::LooksLikeNumber) = 1.39.1
1 perl-Scalar-Util-LooksLikeNumber = 1.39.1-1.fc22
1 perl-Scalar-Util-LooksLikeNumber(x86-64) = 1.39.1-1.fc22
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/x86_64/perl-Scalar-Util-LooksLikeNumber-1.39.1-1.fc22.x86_64.rpm
Binary dependencies resolvable. Ok.
Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7564819). Ok.
Package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.
New Package SCM Request ======================= Package Name: perl-Scalar-Util-LooksLikeNumber Short Description: Access to looks_like_number() perl API function Upstream URL: http://search.cpan.org/dist/Scalar-Util-LooksLikeNumber/ Owners: psabata jplesnik ppisar Branches: f21 InitialCC: perl-sig Git done (by process-git-requests). perl-Scalar-Util-LooksLikeNumber-1.39.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-Scalar-Util-LooksLikeNumber-1.39.1-1.fc21 Thanks! perl-Scalar-Util-LooksLikeNumber-1.39.1-1.fc21 has been pushed to the Fedora 21 stable repository. |