Spec URL: https://psabata.fedorapeople.org/pkgs/perl-Data-Dump-Color/perl-Data-Dump-Color.spec SRPM URL: https://psabata.fedorapeople.org/pkgs/perl-Data-Dump-Color/perl-Data-Dump-Color-0.21-1.fc20.src.rpm Description: This module aims to be a drop-in replacement for Data::Dump. It adds colors to dumps. For more information, see Data::Dump. This documentation explains what's different between this module and Data::Dump. Fedora Account System Username: psabata
License is correct. Package builds in rawhide at http://koji.fedoraproject.org/koji/taskinfo?taskID=7576674 rpmlint is clean Indented evaled require of MIME::Base64 in lib/Data/Dump/Color.pm at line 696 will need a BuildRequires as well as a runtime Requires
The dependency is optional and I left it out deliberately. I can add it if you think it makes sense.
My reading of the code is that MIME::Base64 will be required if the user input contains more than 50 bytes AND is not UTF8. eg. MIME::Base64 will be required for the following; my $str = ''; $str .= chr ( rand ( 255) ) foreach ( 1 .. 100 ); dd("$str"); This will include things like inlined images, etc. I think it's worth including.
It is preferred for long input but not necessary. Anyhow, updating. Adding MIME::Base64 and chagning Data::Dump::Filtered and Data::Dump::FilterContext to runtime deps; this was actually a typo. The test suite only checks if the module loads. SPEC: https://psabata.fedorapeople.org/pkgs/perl-Data-Dump-Color/perl-Data-Dump-Color.spec SRPM: https://psabata.fedorapeople.org/pkgs/perl-Data-Dump-Color/perl-Data-Dump-Color-0.21-2.fc20.src.rpm
Ok. Approved.
Thank you, David.
New Package SCM Request ======================= Package Name: perl-Data-Dump-Color Short Description: Like Data::Dump, but with color Upstream URL: http://search.cpan.org/dist/Data-Dump-Color/ Owners: psabata jplesnik ppisar Branches: f21 InitialCC: perl-sig
Git done (by process-git-requests).
perl-Data-Dump-Color-0.21-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-Data-Dump-Color-0.21-2.fc21
perl-Data-Dump-Color-0.21-2.fc21 has been pushed to the Fedora 21 stable repository.