Bug 1140223
| Summary: | Review Request: perl-Data-Dump-Color - Like Data::Dump, but with color | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Šabata <psabata> |
| Component: | Package Review | Assignee: | David Dick <ddick> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ddick, package-review |
| Target Milestone: | --- | Flags: | ddick:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Data-Dump-Color-0.21-2.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-11-05 16:10:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1140222 | ||
| Bug Blocks: | |||
|
Description
Petr Šabata
2014-09-10 14:07:16 UTC
License is correct. Package builds in rawhide at http://koji.fedoraproject.org/koji/taskinfo?taskID=7576674 rpmlint is clean Indented evaled require of MIME::Base64 in lib/Data/Dump/Color.pm at line 696 will need a BuildRequires as well as a runtime Requires The dependency is optional and I left it out deliberately. I can add it if you think it makes sense. My reading of the code is that MIME::Base64 will be required if the user input contains more than 50 bytes AND is not UTF8.
eg. MIME::Base64 will be required for the following;
my $str = '';
$str .= chr ( rand ( 255) ) foreach ( 1 .. 100 );
dd("$str");
This will include things like inlined images, etc.
I think it's worth including.
It is preferred for long input but not necessary. Anyhow, updating. Adding MIME::Base64 and chagning Data::Dump::Filtered and Data::Dump::FilterContext to runtime deps; this was actually a typo. The test suite only checks if the module loads. SPEC: https://psabata.fedorapeople.org/pkgs/perl-Data-Dump-Color/perl-Data-Dump-Color.spec SRPM: https://psabata.fedorapeople.org/pkgs/perl-Data-Dump-Color/perl-Data-Dump-Color-0.21-2.fc20.src.rpm Ok. Approved. Thank you, David. New Package SCM Request ======================= Package Name: perl-Data-Dump-Color Short Description: Like Data::Dump, but with color Upstream URL: http://search.cpan.org/dist/Data-Dump-Color/ Owners: psabata jplesnik ppisar Branches: f21 InitialCC: perl-sig Git done (by process-git-requests). perl-Data-Dump-Color-0.21-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-Data-Dump-Color-0.21-2.fc21 perl-Data-Dump-Color-0.21-2.fc21 has been pushed to the Fedora 21 stable repository. |