Bug 1141700
Summary: | Do not autoactivate swaps on machine running live images | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Vratislav Podzimek <vpodzime> |
Component: | spin-kickstarts | Assignee: | Jeroen van Meeuwen <vanmeeuwen+fedora> |
Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 22 | CC: | admiller, amulhern, anaconda-maint-list, awilliam, bcl, bruno, bugzilla, dlehman, extras-qa, g.kaviyarasu, jonathan, kalevlember, kevin, mcatanzaro+wrong-account-do-not-cc, pschindl, robatino, vanmeeuwen+fedora, vpodzime |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | x86_64 | ||
OS: | Unspecified | ||
Whiteboard: | abrt_hash:7bbee9d4e3332a8bc2b607e5e1a816ffb3113e81a82a8355c37899dbfae54204 | ||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | 1114786 | Environment: | |
Last Closed: | 2016-07-19 12:08:12 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Vratislav Podzimek
2014-09-15 09:30:19 UTC
> I don't think swap should be auto-activated by booting a live image -- we
> shouldn't be touching the user's disks until they tell us to. The live
> script should be disabling automounting, and if this also happens with
> non-live we should do the same in lorax.
Any suggestion how the live media should be disabling automatic swap activation?
systemd activates swap partitions based on two different mechanisms, both are executables in /usr/lib/systemd/system-generators. The generators are run on start-up and create native systemd units for mounts. The first, systemd-fstab-generator, reads the fstab to generate units, including a unit for swap. The second, systemd-gpt-auto-generator inspects the root disk to generate units. It operates on GPT disks only, and can identify swap partitions by their type code 82. [1] So I guess we need to somehow disable only the swap functionality of these generators.... [1] https://wiki.archlinux.org/index.php/Swap#Activation_by_systemd Note https://bugzilla.redhat.com/show_bug.cgi?id=1114786#c19 . I think there's some misunderstanding going on here, and it may not be systemd activating the swaps at all; there is code in the 'livesys' service that runs on live image boot to activate all swaps it finds on the system, and that code has been there for years. I tried to reproduce this. I installed disk without using lvm (/boot, / and swap), then I used anaconda to delete all (even with custom partitioning as described here) and no error appeared. Is this bug still valid? When I run free in console, system used old swap and after anaconda reformated the disk the live system seemed to use new swap. Do you have a GPT partition table? Anyway, this is really the same issue as bug #1114786; there's been some discussion there recently.... Discussed at 2014-10-03 blocker review meeting: http://meetbot.fedoraproject.org/fedora-blocker-review/2014-10-03/f21-blocker-review.2014-10-03-15.58.log.txt . We're not sure if it's useful to have a second bug open or not so we won't dupe this, but we'll at least state that for blocker review purposes, we'll consider #1114786 as the bug that holds potential blocker status, therefore we're 'un-nominating' this one. This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle. Changing version to '22'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22 Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |