+++ This bug was initially created as a clone of Bug #1114786 +++

Description of problem:
1. Prior F21 installation.
2. Click on one of the prior install partitions, and chose to delete it, and ticked box to remove all related partitions.
3. The prior swap is being used by the live environment so it can't be deleted. Selected it, ticket the Reformat box and clicked Update settings.
CRASH

Version-Release number of selected component:
anaconda-core-21.45-1.fc21.x86_64

The following was filed automatically by anaconda:
anaconda 21.45-1 exception report
Traceback (most recent call first):
  File "/usr/lib/python2.7/site-packages/blivet/devices.py", line 1039, in _setFormat
    raise errors.DeviceError("cannot replace active format", self.name)
  File "/usr/lib/python2.7/site-packages/blivet/devices.py", line 1600, in _setFormat
    StorageDevice._setFormat(self, fmt)
  File "/usr/lib/python2.7/site-packages/blivet/devices.py", line 1048, in <lambda>
    lambda d,f: d._setFormat(f),
  File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/custom.py", line 807, in _do_reformat
    device.format = old_format
  File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/custom.py", line 120, in decorated
    return func(*args, **kwargs)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/custom.py", line 1147, in _save_right_side
    encrypted, selector, fs_type)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/custom.py", line 2490, in on_update_settings_clicked
    self._save_right_side(self._current_selector)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/utils.py", line 241, in _run_once_one_arg
    self._func(*args, **kwargs)
DeviceError: ('cannot replace active format', 'sda6')

Additional info:
cmdline:        /usr/bin/python  /sbin/anaconda --liveinst --method=livecd:///dev/mapper/live-base
cmdline_file:   BOOT_IMAGE=/syslinux/vmlinuz0 elevator=deadline nomodeset enforcing=0 root=live:UUID=82A4-FF9A rw rd.live.image overlay=UUID=82A4-FF9A
executable:     /sbin/anaconda
hashmarkername: anaconda
kernel:         3.16.0-0.rc2.git1.1.fc21.x86_64
other involved packages: python-blivet-0.59-1.fc21.noarch, anaconda-gui-21.45-1.fc21.x86_64
product:        Fedora
release:        Fedora release 21 (Rawhide)
type:           anaconda
version:        rawhide

--- Additional comment from Chris Murphy on 2014-06-30 22:34:14 EDT ---



--- Additional comment from Chris Murphy on 2014-06-30 22:34:16 EDT ---



--- Additional comment from Chris Murphy on 2014-06-30 22:34:18 EDT ---



--- Additional comment from Chris Murphy on 2014-06-30 22:34:25 EDT ---



--- Additional comment from Chris Murphy on 2014-06-30 22:34:27 EDT ---



--- Additional comment from Chris Murphy on 2014-06-30 22:34:28 EDT ---



--- Additional comment from Chris Murphy on 2014-06-30 22:34:29 EDT ---



--- Additional comment from Chris Murphy on 2014-06-30 22:34:31 EDT ---



--- Additional comment from Chris Murphy on 2014-06-30 22:34:34 EDT ---



--- Additional comment from Chris Murphy on 2014-06-30 22:34:36 EDT ---



--- Additional comment from Chris Murphy on 2014-09-06 16:25:59 EDT ---

Still get this when reformatting an existing active swap partition, which is the only way I can see how to reuse an existing swap partition in the UI. I'd rather be allowed to just add the current swap leaving it active, rather than reformat it.

anaconda-21.48.4-1.fc21.i686
python-blivet-0.62-1.fc21.noarch

--- Additional comment from Fedora Blocker Bugs Application on 2014-09-06 16:31:08 EDT ---

Proposed as a Blocker for 21-beta by Fedora user chrismurphy using the blocker tracking app because:

 When using the custom partitioning flow, the installer must be able to: Assign mount points to existing storage volumes.

Strictly speaking swap isn't a mount point, but we can take our pick. I should be able to either reuse an existing swap partition, or reformat it, and in any case not get a crash.

--- Additional comment from Vratislav Podzimek on 2014-09-08 02:57:39 EDT ---

I'm not sure blivet could fix this. Existing swap in use can hardly be reformatted or deactivated by blivet. And using a swap device without reformatting for a new system can be quite dangerous as it can be being used by the other system at that point (hibernated system or anything else). Maybe anaconda could turn off those swap devices when starting? Or maybe we should disable automatic swap activation in the live system? The latter seems to me as the best option. Brian, what is your opinion on this?

--- Additional comment from Chris Murphy on 2014-09-08 14:54:25 EDT ---

The test system uses EFI/GPT, and swap partition has the linux swap partition type GUID set, therefore systemd auto-activates it even though it's not in the live install media fstab. This is probably not common yet, the common case is swap on LVM LV, which is not auto-activated. 

I'm not super familiar with the systemd autoactivate swap code, but it does seem to have a check whether there's a hibernation image in place on swap so I don't think you have to worry about this. In which case the right automatic thing to do is keep it active, and do nothing. It doesn't even need to be added to fstab.

So it's actually an interesting UI/UX issue. If this active swap is left alone, it will be used by the newly installed system via systemd autoactivation. So which is better for Manual Partitioning UI when the user clicks the blue link to create things automatically? a.) Don't include swap partitions with GPT partition type GUID, even though it is being used and will be used in the new install; b.) "fib" by showing it listed as part of the current installation but don't put it in fstab; c.) show it listed as part of the installation but do include it in fstab; d.) create a new swap partition.

I'd say d is not great. It wastes space. I'd opt for b or c, more likely b. It's more truth than fib, even though an fstab entry isn't being created.

--- Additional comment from bcl on 2014-09-09 17:19:53 EDT ---

First off, we shouldn't traceback so we should figure out a clean way to deal with it.

I don't think swap should be auto-activated by booting a live image -- we shouldn't be touching the user's disks until they tell us to. The live script should be disabling automounting, and if this also happens with non-live we should do the same in lorax.

--- Additional comment from Vratislav Podzimek on 2014-09-11 04:53:05 EDT ---

(In reply to bcl from comment #15)
> First off, we shouldn't traceback so we should figure out a clean way to
> deal with it.
Anaconda shouldn't allow reformatting a device that is in use, resassigning back to anaconda.

> 
> I don't think swap should be auto-activated by booting a live image -- we
> shouldn't be touching the user's disks until they tell us to. The live
> script should be disabling automounting, and if this also happens with
> non-live we should do the same in lorax.
It happens only in live installations. What is the right component to clone this bug to?

--- Additional comment from bcl on 2014-09-11 11:35:38 EDT ---

(In reply to Vratislav Podzimek from comment #16)
> (In reply to bcl from comment #15)
> > First off, we shouldn't traceback so we should figure out a clean way to
> > deal with it.
> Anaconda shouldn't allow reformatting a device that is in use, resassigning
> back to anaconda.

But python-blivet really shouldn't traceback either.

> > I don't think swap should be auto-activated by booting a live image -- we
> > shouldn't be touching the user's disks until they tell us to. The live
> > script should be disabling automounting, and if this also happens with
> > non-live we should do the same in lorax.
> It happens only in live installations. What is the right component to clone
> this bug to?

spin-kickstarts

--- Additional comment from Michael Catanzaro on 2014-09-12 22:38:12 EDT ---