Bug 1141829

Summary: No error thrown in common_sp functions in case column or table does not exists
Product: Red Hat Enterprise Virtualization Manager Reporter: Shirly Radco <sradco>
Component: ovirt-engineAssignee: Eli Mesika <emesika>
Status: CLOSED CURRENTRELEASE QA Contact: Petr Kubica <pkubica>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.5.0CC: aberezin, amureini, ecohen, emesika, gklein, iheim, lpeer, oourfali, pstehlik, rbalakri, Rhev-m-bugs, sradco, yeylon
Target Milestone: ---   
Target Release: 3.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: infra
Fixed In Version: org.ovirt.engine-root-3.5.0-18 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-02-17 17:13:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Shirly Radco 2014-09-15 14:33:10 UTC
Description of problem:
When using functions like "fn_db_change_column_type" , if we use a column or table the function is not applied and no error is raised.

Version-Release number of selected component (if applicable):


How reproducible:


Actual results:
The function is not applied and no error is raised

Expected results:
Needs to get an error.

Comment 1 Eli Mesika 2014-09-15 14:47:37 UTC
(In reply to Shirly Radco from comment #0)
> Description of problem:
> When using functions like "fn_db_change_column_type" , if we use a column or
> table the function is not applied and no error is raised.

if we use a column or table => if we use unknown column or table

Comment 3 Shirly Radco 2014-09-18 12:35:32 UTC
In order to test this you will need to create an upgrade script that uses the functions:
fn_db_drop_column, fn_db_change_column_type, fn_db_rename_column
and use as parameters table or column that do not exist and run from the dbscripts the schema.sh.

Shirly

Comment 9 Petr Kubica 2014-11-14 09:44:41 UTC
Verified:
psql:./upgrade/03_05_1160_test.sql:1: ERROR:  Table datacenter_daily_history or Column test does not exist.
FATAL: Cannot execute sql command: --file=./upgrade/03_05_1160_test.sql

rhevm: rhevm-3.5.0-0.20.el6ev.noarch

Comment 10 Eyal Edri 2015-02-17 17:13:51 UTC
rhev 3.5.0 was released. closing.