Bug 1141829 - No error thrown in common_sp functions in case column or table does not exists
Summary: No error thrown in common_sp functions in case column or table does not exists
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.5.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: 3.5.0
Assignee: Eli Mesika
QA Contact: Petr Kubica
URL:
Whiteboard: infra
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-15 14:33 UTC by Shirly Radco
Modified: 2016-02-10 19:21 UTC (History)
13 users (show)

Fixed In Version: org.ovirt.engine-root-3.5.0-18
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-17 17:13:51 UTC
oVirt Team: Infra
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 32959 0 None None None Never
oVirt gerrit 33851 0 ovirt-engine-3.5 MERGED db:add tab/col name validation to common functions Never

Description Shirly Radco 2014-09-15 14:33:10 UTC 
Description of problem:
When using functions like "fn_db_change_column_type" , if we use a column or table the function is not applied and no error is raised.

Version-Release number of selected component (if applicable):


How reproducible:


Actual results:
The function is not applied and no error is raised

Expected results:
Needs to get an error.
Comment 1 Eli Mesika 2014-09-15 14:47:37 UTC 
(In reply to Shirly Radco from comment #0)
> Description of problem:
> When using functions like "fn_db_change_column_type" , if we use a column or
> table the function is not applied and no error is raised.

if we use a column or table => if we use unknown column or table
Comment 3 Shirly Radco 2014-09-18 12:35:32 UTC 
In order to test this you will need to create an upgrade script that uses the functions:
fn_db_drop_column, fn_db_change_column_type, fn_db_rename_column
and use as parameters table or column that do not exist and run from the dbscripts the schema.sh.

Shirly
Comment 9 Petr Kubica 2014-11-14 09:44:41 UTC 
Verified:
psql:./upgrade/03_05_1160_test.sql:1: ERROR:  Table datacenter_daily_history or Column test does not exist.
FATAL: Cannot execute sql command: --file=./upgrade/03_05_1160_test.sql

rhevm: rhevm-3.5.0-0.20.el6ev.noarch
Comment 10 Eyal Edri 2015-02-17 17:13:51 UTC 
rhev 3.5.0 was released. closing.
Note You need to log in before you can comment on or make changes to this bug.