Bug 1142508

Summary:	Review Request: rubygem-true - Testing framework for Sass libraries
Product:	[Fedora] Fedora	Reporter:	Mo Morsi <mmorsi>
Component:	Package Review	Assignee:	Vít Ondruch <vondruch>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, vondruch
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-13 15:33:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449, 1132670

Description Mo Morsi 2014-09-16 23:02:37 UTC

Spec URL: https://mmorsi.fedorapeople.org/staging/rubygem-true.spec
SRPM URL: https://mmorsi.fedorapeople.org/staging/rubygem-true-0.2.3-1.fc20.src.rpm
Description: Unit tests for maintaining test-driven Sass libraries.
Fedora Account System Username: mmorsi

Comment 1 Vít Ondruch 2014-12-22 11:03:18 UTC

I'm taking this for a review.

Comment 2 Vít Ondruch 2014-12-22 11:39:15 UTC

* The .spec file you are linking differs from the .spec from SRPM
  - But the difference is just subtle, so not a blocker.

* Update to the latest upstream version.
  - There is already available true 1.0.1. Please consider update to the latest
    upstream version.

* Test suite
  - Could you please execute the gem's test suite?
  - Since there seems to be circular dependency, I suggest you to follow the
    bootstrapping guidelines [1].
  - When the test suite is shipped in separate source package, I prefer to
    unpack it in the %check section. It does not pollute the original
    installation then.

* License file should be in main package
  - Please move the LICENSE.txt file into main package.

* Move the VERSION file into -doc sub-package
  - It does not look like the VERSION file is used for runtime. Please move it
    into the -doc subpackage.


[1] https://fedoraproject.org/wiki/Packaging:Guidelines#Bootstrapping

Comment 3 Vít Ondruch 2014-12-22 12:07:27 UTC

> * Test suite
>   - Since there seems to be circular dependency, I suggest you to follow the
>     bootstrapping guidelines [1].
>   - When the test suite is shipped in separate source package, I prefer to
>     unpack it in the %check section. It does not pollute the original
>     installation then.

Actually, looking into compass-core, it might make more sense to boostrap compass-core instead of rubygem-true.

Comment 4 Vít Ondruch 2017-07-27 10:39:41 UTC

Ping? Any progress? This looks a bit stalled ...

Comment 5 Package Review 2020-07-10 00:50:37 UTC

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 6 Vít Ondruch 2020-07-13 15:33:36 UTC

Closing as stalled review.