Spec URL: https://mmorsi.fedorapeople.org/staging/rubygem-true.spec SRPM URL: https://mmorsi.fedorapeople.org/staging/rubygem-true-0.2.3-1.fc20.src.rpm Description: Unit tests for maintaining test-driven Sass libraries. Fedora Account System Username: mmorsi
I'm taking this for a review.
* The .spec file you are linking differs from the .spec from SRPM - But the difference is just subtle, so not a blocker. * Update to the latest upstream version. - There is already available true 1.0.1. Please consider update to the latest upstream version. * Test suite - Could you please execute the gem's test suite? - Since there seems to be circular dependency, I suggest you to follow the bootstrapping guidelines [1]. - When the test suite is shipped in separate source package, I prefer to unpack it in the %check section. It does not pollute the original installation then. * License file should be in main package - Please move the LICENSE.txt file into main package. * Move the VERSION file into -doc sub-package - It does not look like the VERSION file is used for runtime. Please move it into the -doc subpackage. [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Bootstrapping
> * Test suite > - Since there seems to be circular dependency, I suggest you to follow the > bootstrapping guidelines [1]. > - When the test suite is shipped in separate source package, I prefer to > unpack it in the %check section. It does not pollute the original > installation then. Actually, looking into compass-core, it might make more sense to boostrap compass-core instead of rubygem-true.
Ping? Any progress? This looks a bit stalled ...
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted.
Closing as stalled review.