Bug 1145654
| Summary: | /usr/share/spamassassin/sa-update.cron is not ready for systemd (related to amavisd-new, spampd) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert Scheck <redhat-bugzilla> | ||||
| Component: | spamassassin | Assignee: | Kevin Fenzi <kevin> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | jorti, kevin, nb, plautrba, wtogami | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | spamassassin-3.4.0-12.fc21 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-10-01 04:22:03 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
ok. I agree your patch makes things use systemctl properly and am happy to apply in rawhide, however, I am not sure how it breaks things... /sbin/service forwards to systemctl, so those calls should still work. Do you have a case where it really breaks something? (In reply to Kevin Fenzi from comment #1) > Do you have a case where it really breaks something? From my point of view, /etc/init.d/amavisd does not exist anymore - it has been replaced by a .service meanwhile. ok. I misread it. I'll see about applying this and pushing it out... It doesn't look like it affects f19? (amavisd-new moved to systemd in f20?) (In reply to Kevin Fenzi from comment #3) > It doesn't look like it affects f19? (amavisd-new moved to systemd in f20?) amavisd-new moves to systemd in f21. It still keeps the old init scripts in f20. great. Then we need just f21 and rawhide. Will push those out... spamassassin-3.4.0-12.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/spamassassin-3.4.0-12.fc21 (In reply to Kevin Fenzi from comment #3) > It doesn't look like it affects f19? (amavisd-new moved to systemd in f20?) Yes, sorry. I thought amavisd-new was already longer on systemd. Package spamassassin-3.4.0-12.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing spamassassin-3.4.0-12.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-11704/spamassassin-3.4.0-12.fc21 then log in and leave karma (feedback). spamassassin-3.4.0-12.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 940421 [details] spamassassin-3.4.0-sa-update_systemd.patch Description of problem: Using amavisd-new together with SpamAssassin leads to the result that /usr/share/spamassassin/sa-update.cron never performs the condrestart of amavisd-new (or spampd) even if the services are up/running. This is because the script still looks for initscript files rather checking the systemd service files or the status. Having no condrestart (or reload; depends on the kind of service itself) leads usually to no refresh of possible updates of the SpamAssassin channel for the given service aka consumer (such as amavisd). Version-Release number of selected component (if applicable): spamassassin-3.4.0-11.fc22 spamassassin-3.4.0-9.fc21 spamassassin-3.4.0-7.fc20 spamassassin-3.4.0-7.fc19 How reproducible: Everytime, see above. Actual results: /usr/share/spamassassin/sa-update.cron is not ready for systemd (related to amavisd-new, spampd). Expected results: Systemd-ready /usr/share/spamassassin/sa-update.cron script. Additional info: Even MIMEDefang is not yet systemd enabled the script is already forward and backward safe (it will get systemd enabled sooner or later, I am the Fedora package maintainer for MIMEDefang).