Bug 1145654 - /usr/share/spamassassin/sa-update.cron is not ready for systemd (related to amavisd-new, spampd)
Summary: /usr/share/spamassassin/sa-update.cron is not ready for systemd (related to a...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: spamassassin
Version: rawhide
Hardware: All
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-23 12:42 UTC by Robert Scheck
Modified: 2014-10-01 04:22 UTC (History)
5 users (show)

Fixed In Version: spamassassin-3.4.0-12.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-10-01 04:22:03 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
spamassassin-3.4.0-sa-update_systemd.patch (1.21 KB, patch)
2014-09-23 12:42 UTC, Robert Scheck
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1145652 0 unspecified CLOSED /usr/share/spamassassin/sa-update.cron is not ready for systemd (related to amavisd-new, spampd) 2021-02-22 00:41:40 UTC

Internal Links: 1145652

Description Robert Scheck 2014-09-23 12:42:59 UTC
Created attachment 940421 [details]
spamassassin-3.4.0-sa-update_systemd.patch

Description of problem:
Using amavisd-new together with SpamAssassin leads to the result that
/usr/share/spamassassin/sa-update.cron never performs the condrestart
of amavisd-new (or spampd) even if the services are up/running. This
is because the script still looks for initscript files rather checking
the systemd service files or the status. Having no condrestart (or reload; 
depends on the kind of service itself) leads usually to no refresh of
possible updates of the SpamAssassin channel for the given service aka
consumer (such as amavisd).

Version-Release number of selected component (if applicable):
spamassassin-3.4.0-11.fc22
spamassassin-3.4.0-9.fc21
spamassassin-3.4.0-7.fc20
spamassassin-3.4.0-7.fc19

How reproducible:
Everytime, see above.

Actual results:
/usr/share/spamassassin/sa-update.cron is not ready for systemd (related to 
amavisd-new, spampd).

Expected results:
Systemd-ready /usr/share/spamassassin/sa-update.cron script.

Additional info:
Even MIMEDefang is not yet systemd enabled the script is already forward and
backward safe (it will get systemd enabled sooner or later, I am the Fedora
package maintainer for MIMEDefang).

Comment 1 Kevin Fenzi 2014-09-25 02:01:43 UTC
ok. I agree your patch makes things use systemctl properly and am happy to apply in rawhide, however, I am not sure how it breaks things... /sbin/service forwards to systemctl, so those calls should still work. 

Do you have a case where it really breaks something?

Comment 2 Robert Scheck 2014-09-25 06:53:10 UTC
(In reply to Kevin Fenzi from comment #1)
> Do you have a case where it really breaks something?

From my point of view, /etc/init.d/amavisd does not exist anymore - it has
been replaced by a .service meanwhile.

Comment 3 Kevin Fenzi 2014-09-25 15:42:03 UTC
ok. I misread it. 

I'll see about applying this and pushing it out... 

It doesn't look like it affects f19? (amavisd-new moved to systemd in f20?)

Comment 4 Juan Orti 2014-09-25 19:17:45 UTC
(In reply to Kevin Fenzi from comment #3)
> It doesn't look like it affects f19? (amavisd-new moved to systemd in f20?)

amavisd-new moves to systemd in f21. It still keeps the old init scripts in f20.

Comment 5 Kevin Fenzi 2014-09-25 20:21:58 UTC
great. Then we need just f21 and rawhide. Will push those out...

Comment 6 Fedora Update System 2014-09-25 20:40:03 UTC
spamassassin-3.4.0-12.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/spamassassin-3.4.0-12.fc21

Comment 7 Robert Scheck 2014-09-26 09:00:14 UTC
(In reply to Kevin Fenzi from comment #3)
> It doesn't look like it affects f19? (amavisd-new moved to systemd in f20?)

Yes, sorry. I thought amavisd-new was already longer on systemd.

Comment 8 Fedora Update System 2014-09-27 10:05:19 UTC
Package spamassassin-3.4.0-12.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing spamassassin-3.4.0-12.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-11704/spamassassin-3.4.0-12.fc21
then log in and leave karma (feedback).

Comment 9 Fedora Update System 2014-10-01 04:22:03 UTC
spamassassin-3.4.0-12.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.