Bug 1146511

Summary: Updating blkdeviotune for live domain doesn't survive restarting the libvirtd
Product: Red Hat Enterprise Linux 7 Reporter: Pavel Hrdina <phrdina>
Component: libvirtAssignee: Pavel Hrdina <phrdina>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.1CC: dyuan, lhuang, phrdina, rbalakri, shyu, xuzhang
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-1.2.8-6.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-03-05 07:45:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Pavel Hrdina 2014-09-25 11:21:24 UTC
Description of problem:
Updating blkdeviotune for live domain doesn't survive restarting the libvirtd

Version-Release number of selected component (if applicable):
libvirt-1.2.8-3.el7

How reproducible:
100%

Steps to Reproduce:
1. set blkdeviotune for running domain
2. restart libvirtd
3. run virsh dumpxml for the domain

Actual results:
changes for blkdeviotune are not present in dumpxml

Expected results:
it should be stored in live XML

Comment 1 Pavel Hrdina 2014-09-25 11:26:12 UTC
Upstream commit:

commit 783fe9ca8c5d1a831d5626c4835a8d3284456d9c
Author: Pavel Hrdina <phrdina>
Date:   Thu Sep 25 11:28:25 2014 +0200

    blkdeviotune: fix bug with saving values into live XML
    
    When you updated some blkdeviotune values for running domain the values
    were stored only internally, but not saved into the live XML so they
    won't survive restarting the libvirtd.
    
    Signed-off-by: Pavel Hrdina <phrdina>

Comment 5 Luyao Huang 2014-09-28 08:34:13 UTC
Hi Pavel,

I have found some virsh command have the same issue:
1.blkiotune --device-weights
steps for reproduce:
[root@localhost ~]# virsh blkiotune r6 
weight         : 500
device_weight  : 
device_read_iops_sec: /dev/sda,1234
device_write_iops_sec: /dev/sda,12345
device_read_bytes_sec: /dev/sda,123456
device_write_bytes_sec: 

[root@localhost ~]# service libvirtd restart
Redirecting to /bin/systemctl restart  libvirtd.service
[root@localhost ~]# virsh blkiotune r6 
weight         : 500
device_weight  : 
device_read_iops_sec: 
device_write_iops_sec: 
device_read_bytes_sec: 
device_write_bytes_sec: 

[root@localhost ~]# virsh blkiotune r6 --device-write-iops-sec /dev/sda,123

[root@localhost ~]# virsh suspend r6
Domain r6 suspended

[root@localhost ~]# service libvirtd restart
Redirecting to /bin/systemctl restart  libvirtd.service
[root@localhost ~]# virsh blkiotune r6 
weight         : 500
device_weight  : 
device_read_iops_sec: 
device_write_iops_sec: /dev/sda,123
device_read_bytes_sec: 
device_write_bytes_sec: 

[root@localhost ~]# virsh resume r6
Domain r6 resumed

[root@localhost ~]# virsh blkiotune r6 
weight         : 500
device_weight  : 
device_read_iops_sec: 
device_write_iops_sec: /dev/sda,123
device_read_bytes_sec: 
device_write_bytes_sec: 

[root@localhost ~]# virsh blkiotune r6 --device-write-iops-sec /dev/sda,0

[root@localhost ~]# virsh blkiotune r6 
weight         : 500
device_weight  : 
device_read_iops_sec: 
device_write_iops_sec: 
device_read_bytes_sec: 
device_write_bytes_sec: 

[root@localhost ~]# service libvirtd restart
Redirecting to /bin/systemctl restart  libvirtd.service
[root@localhost ~]# virsh blkiotune r6 
weight         : 500
device_weight  : 
device_read_iops_sec: 
device_write_iops_sec: /dev/sda,123
device_read_bytes_sec: 
device_write_bytes_sec: 

2.numatune --nodeset
steps for reproduce just like blkiotune


3.domiftune 
steps for reproduce just like blkiotune

Do you think these issue should also be solved ?

Comment 6 Pavel Hrdina 2014-10-06 09:52:44 UTC
Sure, they also should be fixed. I'm reopening the bug to track the issue in RHEL-7.1.

Comment 9 Shanzhi Yu 2014-11-14 09:13:29 UTC
Change to verify, steps as comment 5. Result is expected.

Comment 11 errata-xmlrpc 2015-03-05 07:45:10 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0323.html