RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1146511 - Updating blkdeviotune for live domain doesn't survive restarting the libvirtd
Summary: Updating blkdeviotune for live domain doesn't survive restarting the libvirtd
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Pavel Hrdina
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-25 11:21 UTC by Pavel Hrdina
Modified: 2015-03-05 07:45 UTC (History)
6 users (show)

Fixed In Version: libvirt-1.2.8-6.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-05 07:45:10 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:0323 0 normal SHIPPED_LIVE Low: libvirt security, bug fix, and enhancement update 2015-03-05 12:10:54 UTC

Description Pavel Hrdina 2014-09-25 11:21:24 UTC
Description of problem:
Updating blkdeviotune for live domain doesn't survive restarting the libvirtd

Version-Release number of selected component (if applicable):
libvirt-1.2.8-3.el7

How reproducible:
100%

Steps to Reproduce:
1. set blkdeviotune for running domain
2. restart libvirtd
3. run virsh dumpxml for the domain

Actual results:
changes for blkdeviotune are not present in dumpxml

Expected results:
it should be stored in live XML

Comment 1 Pavel Hrdina 2014-09-25 11:26:12 UTC
Upstream commit:

commit 783fe9ca8c5d1a831d5626c4835a8d3284456d9c
Author: Pavel Hrdina <phrdina>
Date:   Thu Sep 25 11:28:25 2014 +0200

    blkdeviotune: fix bug with saving values into live XML
    
    When you updated some blkdeviotune values for running domain the values
    were stored only internally, but not saved into the live XML so they
    won't survive restarting the libvirtd.
    
    Signed-off-by: Pavel Hrdina <phrdina>

Comment 5 Luyao Huang 2014-09-28 08:34:13 UTC
Hi Pavel,

I have found some virsh command have the same issue:
1.blkiotune --device-weights
steps for reproduce:
[root@localhost ~]# virsh blkiotune r6 
weight         : 500
device_weight  : 
device_read_iops_sec: /dev/sda,1234
device_write_iops_sec: /dev/sda,12345
device_read_bytes_sec: /dev/sda,123456
device_write_bytes_sec: 

[root@localhost ~]# service libvirtd restart
Redirecting to /bin/systemctl restart  libvirtd.service
[root@localhost ~]# virsh blkiotune r6 
weight         : 500
device_weight  : 
device_read_iops_sec: 
device_write_iops_sec: 
device_read_bytes_sec: 
device_write_bytes_sec: 

[root@localhost ~]# virsh blkiotune r6 --device-write-iops-sec /dev/sda,123

[root@localhost ~]# virsh suspend r6
Domain r6 suspended

[root@localhost ~]# service libvirtd restart
Redirecting to /bin/systemctl restart  libvirtd.service
[root@localhost ~]# virsh blkiotune r6 
weight         : 500
device_weight  : 
device_read_iops_sec: 
device_write_iops_sec: /dev/sda,123
device_read_bytes_sec: 
device_write_bytes_sec: 

[root@localhost ~]# virsh resume r6
Domain r6 resumed

[root@localhost ~]# virsh blkiotune r6 
weight         : 500
device_weight  : 
device_read_iops_sec: 
device_write_iops_sec: /dev/sda,123
device_read_bytes_sec: 
device_write_bytes_sec: 

[root@localhost ~]# virsh blkiotune r6 --device-write-iops-sec /dev/sda,0

[root@localhost ~]# virsh blkiotune r6 
weight         : 500
device_weight  : 
device_read_iops_sec: 
device_write_iops_sec: 
device_read_bytes_sec: 
device_write_bytes_sec: 

[root@localhost ~]# service libvirtd restart
Redirecting to /bin/systemctl restart  libvirtd.service
[root@localhost ~]# virsh blkiotune r6 
weight         : 500
device_weight  : 
device_read_iops_sec: 
device_write_iops_sec: /dev/sda,123
device_read_bytes_sec: 
device_write_bytes_sec: 

2.numatune --nodeset
steps for reproduce just like blkiotune


3.domiftune 
steps for reproduce just like blkiotune

Do you think these issue should also be solved ?

Comment 6 Pavel Hrdina 2014-10-06 09:52:44 UTC
Sure, they also should be fixed. I'm reopening the bug to track the issue in RHEL-7.1.

Comment 9 Shanzhi Yu 2014-11-14 09:13:29 UTC
Change to verify, steps as comment 5. Result is expected.

Comment 11 errata-xmlrpc 2015-03-05 07:45:10 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0323.html


Note You need to log in before you can comment on or make changes to this bug.